[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: add guard page to ggtt->error_capture (rev3)

[Andrzej Hajda]

On 03.02.2023 17:35, Patchwork wrote:
> *Patch Details*
> *Series:*	drm/i915: add guard page to ggtt->error_capture (rev3)
> *URL:*	https://patchwork.freedesktop.org/series/113560/ 
> <https://patchwork.freedesktop.org/series/113560/>
> *State:*	failure
> *Details:* 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113560v3/index.html 
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113560v3/index.html>
> 
> 
>   CI Bug Log - changes from CI_DRM_12691 -> Patchwork_113560v3
> 
> 
>     Summary
> 
> *FAILURE*
> 
> Serious unknown changes coming with Patchwork_113560v3 absolutely need to be
> verified manually.
> 
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_113560v3, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
> 
> External URL: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113560v3/index.html
> 
> 
>     Participating hosts (28 -> 26)
> 
> Missing (2): bat-atsm-1 fi-snb-2520m
> 
> 
>     Possible new issues
> 
> Here are the unknown changes that may have been introduced in 
> Patchwork_113560v3:
> 
> 
>       IGT changes
> 
> 
>         Possible regressions
> 
>   * igt at i915_module_load@load:
>       o fi-blb-e6850: PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/fi-blb-e6850/igt@i915_module_load@load.html> -> ABORT <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113560v3/fi-blb-e6850/igt@i915_module_load@load.html>


OK, stacktrace and code checks show clearly scratch[0] is null for ggtt 
on gen < 6:
... ggtt_probe_hw(...)
{
	...
	if (GRAPHICS_VER(i915) >= 8)
		ret = gen8_gmch_probe(ggtt);
	else if (GRAPHICS_VER(i915) >= 6)
		ret = gen6_gmch_probe(ggtt);
	else
		ret = intel_ggtt_gmch_probe(ggtt);
	...
}

And setup_scratch_page for ggtt is called only from gen[68]_gmch_probe.
Anyway, speculative read is observed since gen12 anyway, so limiting to 
gen12+ should be enough to avoid null scratch.

Regards
Andrzej

> 
> 
>         Warnings
> 
>   * igt at i915_selftest@live at execlists:
>       o fi-kbl-soraka: INCOMPLETE
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/fi-kbl-soraka/igt@i915_selftest@live@execlists.html> (i915#7156 <https://gitlab.freedesktop.org/drm/intel/issues/7156>) -> INCOMPLETE <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113560v3/fi-kbl-soraka/igt@i915_selftest@live@execlists.html>
> 
> 
>         Suppressed
> 
> The following results come from untrusted machines, tests, or statuses.
> They do not affect the overall result.
> 
>   * igt at kms_pipe_crc_basic@suspend-read-crc at pipe-d-dp-1:
>       o {bat-adlp-9}: PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/bat-adlp-9/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-dp-1.html> -> DMESG-WARN <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113560v3/bat-adlp-9/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-dp-1.html>
> 
> 
>     Known issues
> 
> Here are the changes found in Patchwork_113560v3 that come from known 
> issues:
> 
> 
>       IGT changes
> 
> 
>         Possible fixes
> 
>   *
> 
>     igt at i915_selftest@live at gt_heartbeat:
> 
>       o fi-apl-guc: DMESG-FAIL
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html> (i915#5334 <https://gitlab.freedesktop.org/drm/intel/issues/5334>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113560v3/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html>
>   *
> 
>     igt at i915_selftest@live at migrate:
> 
>       o {bat-adlp-9}: DMESG-FAIL
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12691/bat-adlp-9/igt@i915_selftest@live@migrate.html> (i915#7699 <https://gitlab.freedesktop.org/drm/intel/issues/7699>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113560v3/bat-adlp-9/igt@i915_selftest@live@migrate.html>
> 
> {name}: This element is suppressed. This means it is ignored when computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
> 
> 
>     Build changes
> 
>   * Linux: CI_DRM_12691 -> Patchwork_113560v3
> 
> CI-20190529: 20190529
> CI_DRM_12691: 2153bc2944d37403c6d5c4e1082d074a34d39ae9 @ 
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_7148: ee8e31cf39c44d3fdbd04d8db239f8a815f86121 @ 
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_113560v3: 2153bc2944d37403c6d5c4e1082d074a34d39ae9 @ 
> git://anongit.freedesktop.org/gfx-ci/linux
> 
> 
>       Linux commits
> 
> 5bccb726f2f4 drm/i915: add guard page to ggtt->error_capture
>