[Intel-gfx] [PATCH 2/2] drm/i915: Add a few more debugs for failed framebuffer creation

[Matt Roper]

On Thu, Feb 16, 2023 at 12:24:26AM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Most of the .fb_create() failure paths are annotated but there
> are a few that seem capable of failing silently (well, higher
> level code should print something, just not anything actually
> useful). Drop a few more hints into the log to aid in debugging.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Reviewed-by: Matt Roper <matthew.d.roper at intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_fb.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
> index 1ba052a127b9..799bdc81a6a9 100644
> --- a/drivers/gpu/drm/i915/display/intel_fb.c
> +++ b/drivers/gpu/drm/i915/display/intel_fb.c
> @@ -2007,6 +2007,7 @@ int intel_framebuffer_init(struct intel_framebuffer *intel_fb,
>  
>  		vm = intel_dpt_create(intel_fb);
>  		if (IS_ERR(vm)) {
> +			drm_dbg_kms(&dev_priv->drm, "failed to create DPT\n");
>  			ret = PTR_ERR(vm);
>  			goto err;
>  		}
> @@ -2049,6 +2050,7 @@ intel_user_framebuffer_create(struct drm_device *dev,
>  	if (HAS_LMEM(i915) && !i915_gem_object_can_migrate(obj, INTEL_REGION_LMEM_0)) {
>  		/* object is "remote", not in local memory */
>  		i915_gem_object_put(obj);
> +		drm_dbg_kms(&i915->drm, "framebuffer must reside in local memory\n");
>  		return ERR_PTR(-EREMOTE);
>  	}
>  
> -- 
> 2.39.1
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation