[Intel-gfx] [PATCH 3/9] drm/i915/perf: Validate OA sseu config outside switch

Dixit, Ashutosh ashutosh.dixit at intel.com
Thu Feb 16 05:36:50 UTC 2023


On Wed, 15 Feb 2023 21:08:43 -0800, Dixit, Ashutosh wrote:
>
> On Tue, 14 Feb 2023 16:54:13 -0800, Umesh Nerlige Ramappa wrote:
> >
> > Validate the OA sseu config after all params are parsed.
>
> Commit messages for all patches need to answer the "why" or the reason for
> the patch. In this case maybe an overkill but probably something like:
>
> Validate the OA sseu config after all params are parsed since the engine
> can be passed in as part of perf properties.

Also, if we do this the patch should probably be later in the series after
the patch which introduces engine class/instance in the perf properties.


More information about the Intel-gfx mailing list