[Intel-gfx] [PATCH 3/9] drm/i915/perf: Validate OA sseu config outside switch

[Umesh Nerlige Ramappa]

On Thu, Feb 16, 2023 at 08:31:21AM -0800, Dixit, Ashutosh wrote:
>On Wed, 15 Feb 2023 21:36:50 -0800, Dixit, Ashutosh wrote:
>>
>> On Wed, 15 Feb 2023 21:08:43 -0800, Dixit, Ashutosh wrote:
>> >
>> > On Tue, 14 Feb 2023 16:54:13 -0800, Umesh Nerlige Ramappa wrote:
>> > >
>> > > Validate the OA sseu config after all params are parsed.
>> >
>> > Commit messages for all patches need to answer the "why" or the reason for
>> > the patch. In this case maybe an overkill but probably something like:
>> >
>> > Validate the OA sseu config after all params are parsed since the engine
>> > can be passed in as part of perf properties.
>>
>> Also, if we do this the patch should probably be later in the series after
>> the patch which introduces engine class/instance in the perf properties.
>
>General guidelines for submitting a patch series for review (for the
>future):
>
>1. The commit message should explain "why" or reason for a patch
>2. As far as possible patches should be in a logical order so the series
>   should "tell a story"
>3. The patches should be small (each patch being a single logical change if
>   possible)
>
>So after we've done the hard part of figuring out the code and getting it
>to work, the above guidelines also make the review process easier.

will do and post a new revision.

Thanks,
Umesh

>
>Thanks.
>--
>Ashutosh