[Intel-gfx] [PATCH] Revert "drm/shmem-helper: Switch to reservation lock"

[Saarinen, Jani]

> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces at lists.freedesktop.org> On Behalf Of Thomas
> Zimmermann
> Sent: tiistai 28. helmikuuta 2023 17.46
> To: Dmitry Osipenko <dmitry.osipenko at collabora.com>;
> maarten.lankhorst at linux.intel.com; airlied at gmail.com; daniel at ffwll.ch; Nikula,
> Jani <jani.nikula at intel.com>
> Cc: intel-gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] Revert "drm/shmem-helper: Switch to
> reservation lock"
> 
> Hi
> 
> Am 28.02.23 um 16:28 schrieb Dmitry Osipenko:
> > On 2/28/23 18:26, Thomas Zimmermann wrote:
> >> This reverts commit 67b7836d4458790f1261e31fe0ce3250989784f0.
> >>
> >> The locking appears incomplete. A caller of SHMEM helper's pin
> >> function never acquires the dma-buf reservation lock. So we get
> >>
> >>    WARNING: CPU: 3 PID: 967 at
> >> drivers/gpu/drm/drm_gem_shmem_helper.c:243
> >> drm_gem_shmem_pin+0x42/0x90 [drm_shmem_helper]
> >>
> >> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> >> ---
> >
> > Thanks Thomas,
> >
> > Acked-by: Dmitry Osipenko <dmitry.osipenko at collabora.com>
> >
> 
> Thanks, merged now. I hope this fixes the immediate issues.
According to pre-merge results: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114478v1/index.html? 
So should fix. 

> 
> Best regards
> Thomas
> 
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> (HRB 36809, AG Nürnberg)
> Geschäftsführer: Ivo Totev