[Intel-gfx] [PATCH 1/1] drm/i915/gsc: Fix the Driver-FLR completion

[Teres Alexis, Alan Previn]

On Fri, 2023-01-20 at 08:27 +0000, Gupta, Anshuman wrote:
> 
> 
> > -----Original Message-----
> > From: Intel-gfx <intel-gfx-bounces at lists.freedesktop.org> On Behalf Of Alan
> > Previn
> > Sent: Friday, January 20, 2023 1:20 AM
> > To: intel-gfx at lists.freedesktop.org
> > Cc: Vivi at freedesktop.org; dri-devel at lists.freedesktop.org; Teres Alexis,
> > Alan Previn <alan.previn.teres.alexis at intel.com>; Vivi, Rodrigo
> > <rodrigo.vivi at intel.com>
> > Subject: [Intel-gfx] [PATCH 1/1] drm/i915/gsc: Fix the Driver-FLR completion
> > 
> > 
alan:snip..

> > +       /* Completion Step 1 - poll for 'CNTL-BIT31 = 0' wait for hw teardown
> > to complete */
> > +       ret = intel_wait_for_register_fw(uncore, GU_CNTL,
> > +                                        DRIVERFLR_STATUS, 0,
> > +                                        flr_timeout_ms);
> We need an error here if above wait timeout then below wait is essentially a NOP.
> And driver may return before completion of FLR.
> Thanks,
> Anshuman Gupta.

alan: my bad - good catch - will fix.

alan:snip..