[Intel-gfx] [PATCH v4 1/7] drm/i915: Fix request locking during error capture & debugfs dump

John Harrison john.c.harrison at intel.com
Wed Jan 25 22:04:30 UTC 2023


On 1/23/2023 09:51, Tvrtko Ursulin wrote:
> On 20/01/2023 23:28, John.C.Harrison at Intel.com wrote:
>> From: John Harrison <John.C.Harrison at Intel.com>
>>
>> <snip>
>>
>>   -struct i915_request *intel_context_find_active_request(struct 
>> intel_context *ce)
>> +struct i915_request *intel_context_find_active_request_get(struct 
>> intel_context *ce)
>
> TBH I don't "dig" this name, it's a bit on the long side and feels out 
> of character. I won't insist it be changed, but if get really has to 
> be included in the name I would be happy with 
> intel_context_get_active_request().
Daniele sided with you on this one. Will use your naming.

John.



More information about the Intel-gfx mailing list