[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Add selftests for TLB invalidation (rev6)

Patchwork patchwork at emeril.freedesktop.org
Mon Jan 30 11:58:14 UTC 2023


== Series Details ==

Series: drm/i915/gt: Add selftests for TLB invalidation (rev6)
URL   : https://patchwork.freedesktop.org/series/112894/
State : warning

== Summary ==

Error: dim checkpatch failed
d3a3e008ebc9 drm/i915/gt: Add selftests for TLB invalidation
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:39: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#39: 
new file mode 100644

-:67: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#67: FILE: drivers/gpu/drm/i915/gt/selftest_tlb.c:24:
+	GEM_BUG_ON(addr < i915_vma_offset(vma));

-:68: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#68: FILE: drivers/gpu/drm/i915/gt/selftest_tlb.c:25:
+	GEM_BUG_ON(addr >= i915_vma_offset(vma) + i915_vma_size(vma) + sizeof(val));

-:113: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#113: FILE: drivers/gpu/drm/i915/gt/selftest_tlb.c:70:
+	GEM_BUG_ON(i915_vma_offset(va) != addr);

-:174: WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
#174: FILE: drivers/gpu/drm/i915/gt/selftest_tlb.c:131:
+	msleep(10);

-:210: WARNING:MEMORY_BARRIER: memory barrier without comment
#210: FILE: drivers/gpu/drm/i915/gt/selftest_tlb.c:167:
+	wmb();

-:255: WARNING:LINE_SPACING: Missing a blank line after declarations
#255: FILE: drivers/gpu/drm/i915/gt/selftest_tlb.c:212:
+	enum intel_engine_id id;
+	I915_RND_STATE(prng);

-:289: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#289: FILE: drivers/gpu/drm/i915/gt/selftest_tlb.c:246:
+	GEM_BUG_ON(A->base.size != B->base.size);

-:350: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#350: FILE: drivers/gpu/drm/i915/gt/selftest_tlb.c:307:
+				err = pte_tlbinv(ce, va, vb,
+						BIT_ULL(bit),

total: 0 errors, 8 warnings, 1 checks, 400 lines checked




More information about the Intel-gfx mailing list