[Intel-gfx] [PATCH] drm/i915: Refine mmio debug flow to avoid bad unlock balance detected.

[Andi Shyti]

Hi Jani,

> >> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> >> index 796ebfe6c550..9d665978cc43 100644
> >> --- a/drivers/gpu/drm/i915/intel_uncore.c
> >> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> >> @@ -1931,9 +1931,6 @@ unclaimed_reg_debug(struct intel_uncore *uncore,
> >>  		    const bool read,
> >>  		    const bool before)
> >>  {
> >> -	if (likely(!uncore->i915->params.mmio_debug) || !uncore->debug)
> >> -		return;
> >> -
> >
> > this is a very good catch! I'm fine with the change from my side:
> >
> > Reviewed-by: Andi Shyti <andi.shyti at linux.intel.com>
> 
> Nope, there's a bug in the patch.
> 
> https://lore.kernel.org/r/87ilb00zot.fsf@intel.com

OK, I missed your reply.

Thanks, Jani!

Andi