[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [RFC,1/2] drm/i915: Refactor PAT/object cache handling

[Patchwork]

== Series Details ==

Series: series starting with [RFC,1/2] drm/i915: Refactor PAT/object cache handling
URL   : https://patchwork.freedesktop.org/series/120686/
State : warning

== Summary ==

Error: dim checkpatch failed
49bef4e97877 drm/i915: Refactor PAT/object cache handling
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:734: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#734: FILE: drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c:63:
+i915_ttm_cache_pat(struct drm_i915_private *i915, struct ttm_resource *res,
 		     struct ttm_tt *ttm)

-:1347: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#1347: 
new file mode 100644

-:1352: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1352: FILE: drivers/gpu/drm/i915/i915_cache.c:1:
+/*

-:1353: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#1353: FILE: drivers/gpu/drm/i915/i915_cache.c:2:
+ * SPDX-License-Identifier: MIT

-:1406: WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#1406: FILE: drivers/gpu/drm/i915/i915_cache.c:55:
+	static const char *mode_str[] = {

-:1412: WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#1412: FILE: drivers/gpu/drm/i915/i915_cache.c:61:
+	static const char *flag_str[] = {

-:1462: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1462: FILE: drivers/gpu/drm/i915/i915_cache.h:17:
+#define I915_CACHE(mode) \
+	(i915_cache_t)(I915_CACHE_MODE_##mode)

-:1467: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1467: FILE: drivers/gpu/drm/i915/i915_cache.h:22:
+#define _I915_CACHE(mode, flag) \
+	(i915_cache_t)((I915_CACHE_MODE_##mode) | __I915_CACHE_FLAG(flag))

-:1470: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1470: FILE: drivers/gpu/drm/i915/i915_cache.h:25:
+#define __I915_CACHE(mode, flags) \
+	(i915_cache_t)((I915_CACHE_MODE_##mode) | ((flags) << 8))

-:1473: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1473: FILE: drivers/gpu/drm/i915/i915_cache.h:28:
+#define I915_CACHE_MODE(cache) \
+	(enum i915_cache_mode)(((i915_cache_t)(cache)) & 0xff)

-:1475: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1475: FILE: drivers/gpu/drm/i915/i915_cache.h:30:
+#define I915_CACHE_FLAGS(cache) \
+	(unsigned int)((((i915_cache_t)(cache) & 0xff00)) >> 8)

-:2081: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations
#2081: FILE: drivers/gpu/drm/i915/selftests/mock_gem_device.c:134:
+		[2] = __I915_CACHE(WB, BIT(I915_CACHE_FLAG_COH1W) | BIT(I915_CACHE_FLAG_L3)), \

total: 5 errors, 6 warnings, 1 checks, 1729 lines checked
df03c572f382 drm/i915: Remove PAT hack from i915_gem_object_can_bypass_llc
-:14: WARNING:REPEATED_WORD: Possible repeated word: 'is'
#14: 
index can (bypass the LLC), question is is there a such PAT index on a

total: 0 errors, 1 warnings, 0 checks, 12 lines checked