[Intel-gfx] Intel-gfx Digest, Vol 186, Issue 211
Garg, Nemesa
nemesa.garg at intel.com
Wed Jul 19 09:08:08 UTC 2023
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces at lists.freedesktop.org> On Behalf Of intel-
> gfx-request at lists.freedesktop.org
> Sent: Friday, July 14, 2023 7:10 PM
> To: intel-gfx at lists.freedesktop.org
> Subject: Intel-gfx Digest, Vol 186, Issue 211
>
> Send Intel-gfx mailing list submissions to
> intel-gfx at lists.freedesktop.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> or, via email, send a message with subject or body 'help' to
> intel-gfx-request at lists.freedesktop.org
>
> You can reach the person managing the list at
> intel-gfx-owner at lists.freedesktop.org
>
> When replying, please edit your Subject line so it is more specific than "Re:
> Contents of Intel-gfx digest..."
>
>
> Today's Topics:
>
> 1. [PATCH] drm/i915: Start using plane scale factor for relative
> data rate (Stanislav Lisovskiy)
> 2. Re: [PATCH v9 09/10] vfio/pci: Copy hot-reset device info to
> userspace in the devices loop (Jason Gunthorpe)
> 3. ? Fi.CI.BAT: success for drm/i915: Start using plane scale
> factor for relative data rate (Patchwork)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Fri, 14 Jul 2023 15:34:56 +0300
> From: Stanislav Lisovskiy <stanislav.lisovskiy at intel.com>
> To: intel-gfx at lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH] drm/i915: Start using plane scale factor
> for relative data rate
> Message-ID: <20230714123456.19153-1-stanislav.lisovskiy at intel.com>
>
> BSpec 68907 clearly instructs us to use plane scale factor when calculating
> relative data rate to be used when allocating DDB blocks for each plane.
> For some reason we use scale factor for data_rate calculation, which is used
> for BW calculations, however we are not using it for DDB calculations.
>
> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy at intel.com>
Reviewed-by: Garg, Nemesa <nemesa.garg at intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_atomic_plane.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> index 7d9578ebae556..60a492e186ab8 100644
> --- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> +++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> @@ -212,6 +212,7 @@ intel_plane_relative_data_rate(const struct
> intel_crtc_state *crtc_state,
> struct intel_plane *plane = to_intel_plane(plane_state->uapi.plane);
> const struct drm_framebuffer *fb = plane_state->hw.fb;
> int width, height;
> + unsigned int rel_data_rate;
>
> if (plane->id == PLANE_CURSOR)
> return 0;
> @@ -241,7 +242,11 @@ intel_plane_relative_data_rate(const struct
> intel_crtc_state *crtc_state,
> height /= 2;
> }
>
> - return width * height * fb->format->cpp[color_plane];
> + rel_data_rate = width * height * fb->format->cpp[color_plane];
> +
> + return intel_adjusted_rate(&plane_state->uapi.src,
> + &plane_state->uapi.dst,
> + rel_data_rate);
> }
>
LGTM,
Thanks and Regards,
Nemesa
> int intel_plane_calc_min_cdclk(struct intel_atomic_state *state,
> --
> 2.37.3
>
>
>
> ------------------------------
>
> Message: 2
> Date: Fri, 14 Jul 2023 10:36:55 -0300
> From: Jason Gunthorpe <jgg at nvidia.com>
> To: Yi Liu <yi.l.liu at intel.com>
> Cc: alex.williamson at redhat.com, kevin.tian at intel.com, joro at 8bytes.org,
> robin.murphy at arm.com, cohuck at redhat.com,
> eric.auger at redhat.com,
> nicolinc at nvidia.com, kvm at vger.kernel.org,
> mjrosato at linux.ibm.com,
> chao.p.peng at linux.intel.com, yi.y.sun at linux.intel.com,
> peterx at redhat.com, jasowang at redhat.com,
> shameerali.kolothum.thodi at huawei.com, lulu at redhat.com,
> suravee.suthikulpanit at amd.com, intel-gvt-
> dev at lists.freedesktop.org,
> intel-gfx at lists.freedesktop.org, linux-s390 at vger.kernel.org,
> xudong.hao at intel.com, yan.y.zhao at intel.com,
> terrence.xu at intel.com,
> yanting.jiang at intel.com, zhenzhong.duan at intel.com,
> clegoate at redhat.com
> Subject: Re: [Intel-gfx] [PATCH v9 09/10] vfio/pci: Copy hot-reset
> device info to userspace in the devices loop
> Message-ID: <ZLFPd2coVKPcI05G at nvidia.com>
> Content-Type: text/plain; charset=us-ascii
>
> On Mon, Jul 10, 2023 at 07:31:25PM -0700, Yi Liu wrote:
>
> > @@ -1311,29 +1296,17 @@ static int
> vfio_pci_ioctl_get_pci_hot_reset_info(
> > ret = vfio_pci_for_each_slot_or_bus(vdev->pdev, vfio_pci_fill_devs,
> > &fill, slot);
> > mutex_unlock(&vdev->vdev.dev_set->lock);
> > + if (ret)
> > + return ret;
> >
> > - /*
> > - * If a device was removed between counting and filling, we may
> come up
> > - * short of fill.max. If a device was added, we'll have a return of
> > - * -EAGAIN above.
> > - */
> > - if (!ret) {
> > - hdr.count = fill.cur;
> > - hdr.flags = fill.flags;
> > - }
> > -
> > -reset_info_exit:
> > + hdr.count = fill.count;
> > + hdr.flags = fill.flags;
> > if (copy_to_user(arg, &hdr, minsz))
> > - ret = -EFAULT;
> > -
> > - if (!ret) {
> > - if (copy_to_user(&arg->devices, devices,
> > - hdr.count * sizeof(*devices)))
> > - ret = -EFAULT;
> > - }
> > + return -EFAULT;
> >
> > - kfree(devices);
> > - return ret;
> > + if (fill.count != fill.devices - arg->devices)
> > + return -ENOSPC;
>
> This should be > right? The previous code returned ENOSPC only if
> their were more devices than requested, not less.
>
> Jason
>
>
> ------------------------------
>
> Message: 3
> Date: Fri, 14 Jul 2023 13:40:27 -0000
> From: Patchwork <patchwork at emeril.freedesktop.org>
> To: "Stanislav Lisovskiy" <stanislav.lisovskiy at intel.com>
> Cc: intel-gfx at lists.freedesktop.org
> Subject: [Intel-gfx] ? Fi.CI.BAT: success for drm/i915: Start using
> plane scale factor for relative data rate
> Message-ID:
> <168934202742.13875.17191708900969933819 at emeril.freedesktop.
> org>
> Content-Type: text/plain; charset="utf-8"
>
> == Series Details ==
>
> Series: drm/i915: Start using plane scale factor for relative data rate
> URL : https://patchwork.freedesktop.org/series/120767/
> State : success
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_13385 -> Patchwork_120767v1
> ====================================================
>
> Summary
> -------
>
> **SUCCESS**
>
> No regressions found.
>
> External URL: https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_120767v1/index.html
>
> Participating hosts (41 -> 43)
> ------------------------------
>
> Additional (3): fi-kbl-soraka bat-dg2-13 bat-dg2-14
> Missing (1): fi-snb-2520m
>
> Known issues
> ------------
>
> Here are the changes found in Patchwork_120767v1 that come from known
> issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
> * igt at gem_huc_copy@huc-copy:
> - fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190])
> [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/fi-kbl-
> soraka/igt at gem_huc_copy@huc-copy.html
>
> * igt at gem_lmem_swapping@basic:
> - fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3
> similar issues
> [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/fi-kbl-
> soraka/igt at gem_lmem_swapping@basic.html
>
> * igt at i915_selftest@live at execlists:
> - fi-bsw-nick: [PASS][3] -> [ABORT][4] ([i915#7911] / [i915#7913])
> [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13385/fi-bsw-
> nick/igt at i915_selftest@live at execlists.html
> [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/fi-bsw-
> nick/igt at i915_selftest@live at execlists.html
>
> * igt at i915_selftest@live at gt_heartbeat:
> - fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][5] ([i915#5334] / [i915#7872])
> [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/fi-kbl-
> soraka/igt at i915_selftest@live at gt_heartbeat.html
>
> * igt at i915_selftest@live at gt_pm:
> - fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][6] ([i915#1886] / [i915#7913])
> [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/fi-kbl-
> soraka/igt at i915_selftest@live at gt_pm.html
>
> * igt at i915_selftest@live at slpc:
> - bat-rpls-1: NOTRUN -> [DMESG-WARN][7] ([i915#6367])
> [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/bat-rpls-
> 1/igt at i915_selftest@live at slpc.html
>
> * igt at i915_suspend@basic-s3-without-i915:
> - bat-mtlp-6: NOTRUN -> [SKIP][8] ([i915#6645])
> [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/bat-mtlp-
> 6/igt at i915_suspend@basic-s3-without-i915.html
> - bat-rpls-1: NOTRUN -> [ABORT][9] ([i915#6687] / [i915#7978] /
> [i915#8668])
> [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/bat-rpls-
> 1/igt at i915_suspend@basic-s3-without-i915.html
>
> * igt at kms_chamelium_hpd@common-hpd-after-suspend:
> - bat-mtlp-6: NOTRUN -> [SKIP][10] ([i915#7828])
> [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/bat-
> mtlp-6/igt at kms_chamelium_hpd@common-hpd-after-suspend.html
> - bat-dg2-11: NOTRUN -> [SKIP][11] ([i915#7828])
> [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/bat-dg2-
> 11/igt at kms_chamelium_hpd@common-hpd-after-suspend.html
>
> * igt at kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
> - fi-kbl-soraka: NOTRUN -> [SKIP][12] ([fdo#109271]) +15 similar issues
> [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/fi-kbl-
> soraka/igt at kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
>
> * igt at kms_pipe_crc_basic@read-crc-frame-sequence at pipe-d-edp-1:
> - bat-rplp-1: [PASS][13] -> [ABORT][14] ([i915#8442] / [i915#8668])
> [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13385/bat-rplp-
> 1/igt at kms_pipe_crc_basic@read-crc-frame-sequence at pipe-d-edp-1.html
> [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/bat-
> rplp-1/igt at kms_pipe_crc_basic@read-crc-frame-sequence at pipe-d-edp-
> 1.html
>
> * igt at kms_pipe_crc_basic@suspend-read-crc:
> - bat-mtlp-6: NOTRUN -> [SKIP][15] ([i915#1845] / [i915#4078])
> [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/bat-
> mtlp-6/igt at kms_pipe_crc_basic@suspend-read-crc.html
>
>
> #### Possible fixes ####
>
> * igt at i915_pm_rpm@basic-rte:
> - fi-skl-guc: [FAIL][16] ([i915#7940]) -> [PASS][17]
> [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13385/fi-skl-
> guc/igt at i915_pm_rpm@basic-rte.html
> [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/fi-skl-
> guc/igt at i915_pm_rpm@basic-rte.html
>
> * igt at i915_selftest@live at requests:
> - bat-mtlp-6: [ABORT][18] ([i915#7982]) -> [PASS][19]
> [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13385/bat-mtlp-
> 6/igt at i915_selftest@live at requests.html
> [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/bat-
> mtlp-6/igt at i915_selftest@live at requests.html
>
> * igt at i915_selftest@live at reset:
> - bat-rpls-1: [ABORT][20] ([i915#4983] / [i915#7461] / [i915#8347] /
> [i915#8384]) -> [PASS][21]
> [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13385/bat-rpls-
> 1/igt at i915_selftest@live at reset.html
> [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/bat-
> rpls-1/igt at i915_selftest@live at reset.html
>
> * igt at i915_selftest@live at slpc:
> - bat-rpls-2: [DMESG-WARN][22] ([i915#6367]) -> [PASS][23]
> [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13385/bat-rpls-
> 2/igt at i915_selftest@live at slpc.html
> [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/bat-
> rpls-2/igt at i915_selftest@live at slpc.html
>
> * igt at i915_selftest@live at workarounds:
> - bat-dg2-11: [INCOMPLETE][24] ([i915#7913]) -> [PASS][25]
> [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13385/bat-dg2-
> 11/igt at i915_selftest@live at workarounds.html
> [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/bat-dg2-
> 11/igt at i915_selftest@live at workarounds.html
>
>
> #### Warnings ####
>
> * igt at core_auth@basic-auth:
> - bat-adlp-11: [ABORT][26] ([i915#8011]) -> [ABORT][27] ([i915#4423] /
> [i915#8011])
> [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13385/bat-adlp-
> 11/igt at core_auth@basic-auth.html
> [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120767v1/bat-
> adlp-11/igt at core_auth@basic-auth.html
>
>
> {name}: This element is suppressed. This means it is ignored when
> computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
>
> [Intel XE#484]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/484
> [Intel XE#486]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/486
> [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
> [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
> [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
> [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
> [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
> [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
> [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
> [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
> [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
> [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
> [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
> [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
> [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
> [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
> [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
> [i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
> [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
> [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
> [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
> [i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
> [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
> [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
> [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
> [i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
> [i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
> [i915#7359]: https://gitlab.freedesktop.org/drm/intel/issues/7359
> [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
> [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
> [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
> [i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
> [i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
> [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
> [i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
> [i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
> [i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
> [i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
> [i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
> [i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
> [i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
> [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
>
>
> Build changes
> -------------
>
> * Linux: CI_DRM_13385 -> Patchwork_120767v1
>
> CI-20190529: 20190529
> CI_DRM_13385: f8be3c363790b79801f7be6bd40062219e3789bc @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_7386: 54dc25efaf10d87962f95be9b1d1a8f0f907912b @
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_120767v1: f8be3c363790b79801f7be6bd40062219e3789bc @
> git://anongit.freedesktop.org/gfx-ci/linux
>
>
> ### Linux commits
>
> 5bddc09c8d95 drm/i915: Start using plane scale factor for relative data rate
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_120767v1/index.html
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <https://lists.freedesktop.org/archives/intel-
> gfx/attachments/20230714/28e943d6/attachment.htm>
>
> ------------------------------
>
> Subject: Digest Footer
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>
> ------------------------------
>
> End of Intel-gfx Digest, Vol 186, Issue 211
> *******************************************
More information about the Intel-gfx
mailing list