[Intel-gfx] [PATCH] drm/i915: sync I915_PMU_MAX_GTS to I915_MAX_GT

[Andi Shyti]

Hi Matt,

> > > > --- a/drivers/gpu/drm/i915/i915_pmu.h
> > > > +++ b/drivers/gpu/drm/i915/i915_pmu.h
> > > > @@ -38,7 +38,7 @@ enum {
> > > >  	__I915_NUM_PMU_SAMPLERS
> > > >  };
> > > >  
> > > > -#define I915_PMU_MAX_GTS 2
> > > > +#define I915_PMU_MAX_GTS 4
> > > 
> > > right! Why not having
> > > 
> > > 	#define I915_PMU_MAX_GTS	I915_MAX_GT
> > > 
> > > or... why having I915_PMU_MAX_GTS at all?
> > Originally I went the route of s/I915_PMU_MAX_GTS/I915_MAX_GT/g.
> > However, this introduces many changes to where you then move
> > I915_MAX_GT to and #include blocks in fiels that require these values.
> > In the end I decided it was better to keep define and just change the
> > value.
> 
> OK, makes sense, then how about
> 
>  	#define I915_PMU_MAX_GTS	I915_MAX_GT
> 
> i915_pmu.h has visibility on I915_MAX_GT.

ops... it doesn't... sorry!

Reviewed-by: Andi Shyti <andi.shyti at linux.intel.com> 

Andi

> Andi
> 
> > > 
> > > Andi
> > > 
> > > >  /*
> > > >   * How many different events we track in the global PMU mask.
> > > > -- 
> > > > 2.40.0
> > MattA