[Intel-gfx] [PATCH 1/4] drm/i915: Add missing forward declarations/includes to display power headers

[Randy Dunlap]

Hi--

On 6/16/23 11:51, Imre Deak wrote:
> Add the seq_file struct forward declaration to intel_display_power.h
> fixing the build error below. While at it add the rest of missing
> forward declarations/includes to the display power header files.
> 
> In file included from <command-line>:
> ./../drivers/gpu/drm/i915/display/intel_display_power.h:255:70: error: 'struct seq_file'
> declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>   255 | void intel_display_power_debug(struct drm_i915_private *i915, struct seq_file *m);
>       |                                                                      ^~~~~~~~
> 
> Reported-by: Randy Dunlap <rdunlap at infradead.org>
> Closes: https://lore.kernel.org/intel-gfx/89adc1ac-25a0-6eb6-4cc9-ab6cc8d49730@infradead.org/
> Signed-off-by: Imre Deak <imre.deak at intel.com>

Acked-by: Randy Dunlap <rdunlap at infradead.org>
Tested-by: Randy Dunlap <rdunlap at infradead.org> # build-tested

Thanks.

> ---
>  drivers/gpu/drm/i915/display/intel_display_power.h      | 4 ++++
>  drivers/gpu/drm/i915/display/intel_display_power_well.h | 2 ++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
> index be1a87bde0c9d..df38632c62371 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.h
> @@ -6,6 +6,9 @@
>  #ifndef __INTEL_DISPLAY_POWER_H__
>  #define __INTEL_DISPLAY_POWER_H__
>  
> +#include <linux/mutex.h>
> +#include <linux/workqueue.h>
> +
>  #include "intel_wakeref.h"
>  
>  enum aux_ch;
> @@ -16,6 +19,7 @@ enum port;
>  struct drm_i915_private;
>  struct i915_power_well;
>  struct intel_encoder;
> +struct seq_file;
>  
>  /*
>   * Keep the pipe, transcoder, port (DDI_LANES,DDI_IO,AUX) domain instances
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power_well.h b/drivers/gpu/drm/i915/display/intel_display_power_well.h
> index e494df379e6c2..1015bba4af01e 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power_well.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_power_well.h
> @@ -12,6 +12,8 @@
>  
>  struct drm_i915_private;
>  struct i915_power_well;
> +struct i915_power_well_ops;
> +struct intel_encoder;
>  
>  #define for_each_power_well(__dev_priv, __power_well)				\
>  	for ((__power_well) = (__dev_priv)->display.power.domains.power_wells;	\

-- 
~Randy