[Intel-gfx] [PATCH v3] drm/i915/hdcp: Add a debug statement at hdcp2 capability check

[Borah, Chaitanya Kumar]

> -----Original Message-----
> From: Kandpal, Suraj <suraj.kandpal at intel.com>
> Sent: Thursday, June 22, 2023 7:31 PM
> To: Borah, Chaitanya Kumar <chaitanya.kumar.borah at intel.com>; intel-
> gfx at lists.freedesktop.org
> Cc: jani.nikula at linux.intel.com
> Subject: RE: [PATCH v3] drm/i915/hdcp: Add a debug statement at hdcp2
> capability check
> 
> 
> 
> > -----Original Message-----
> > From: Borah, Chaitanya Kumar <chaitanya.kumar.borah at intel.com>
> > Sent: Thursday, June 22, 2023 7:23 PM
> > To: Kandpal, Suraj <suraj.kandpal at intel.com>; intel-
> > gfx at lists.freedesktop.org
> > Cc: jani.nikula at linux.intel.com
> > Subject: RE: [PATCH v3] drm/i915/hdcp: Add a debug statement at hdcp2
> > capability check
> >
> > Hello Suraj,
> >
> > > -----Original Message-----
> > > From: Kandpal, Suraj <suraj.kandpal at intel.com>
> > > Sent: Wednesday, June 21, 2023 2:25 PM
> > > To: intel-gfx at lists.freedesktop.org
> > > Cc: jani.nikula at linux.intel.com; Borah, Chaitanya Kumar
> > > <chaitanya.kumar.borah at intel.com>; Kandpal, Suraj
> > > <suraj.kandpal at intel.com>
> > > Subject: [PATCH v3] drm/i915/hdcp: Add a debug statement at hdcp2
> > > capability check
> > >
> > > Add a debug statement at hdcp2 capability check which indicates if
> > > GSC CS is causing hdcp2 incapability
> > >
> > > --v2
> > > -correcttypo in commit header
> > >
> > > --v3
> > > -correct the other typo in commit header [Jani]
> > >
> > > Signed-off-by: Suraj Kandpal <suraj.kandpal at intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/display/intel_hdcp.c | 5 ++++-
> > >  1 file changed, 4 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c
> > > b/drivers/gpu/drm/i915/display/intel_hdcp.c
> > > index 5ed450111f77..73fe84fc9bf5 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_hdcp.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
> > > @@ -177,8 +177,11 @@ bool intel_hdcp2_capable(struct intel_connector
> > > *connector)
> > >  		struct intel_gt *gt = i915->media_gt;
> > >  		struct intel_gsc_uc *gsc = gt ? &gt->uc.gsc : NULL;
> > >
> > > -		if (!gsc || !intel_uc_fw_is_running(&gsc->fw))
> > > +		if (!gsc || !intel_uc_fw_is_running(&gsc->fw)) {
> > > +			drm_dbg_kms(&i915->drm,
> > > +				    "GSC components required for HDCP2.2
> > are
> > > not ready\n");
> >
> > The change looks good to me. Only a small query, Is it important to
> > know at this point, for which condition out of the two, we actually fail?
> >
> 
> Normally we had a clear indication what caused hdcp2.2 incapability but with
> addition of gsc we needed a debug statement for this and both the above
> condition if failed point towards gsc being an issue which make me reason
> that we wouldn't need to differentiate which of the two conditions failed.
> 

Noted. LGTM.

Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah at intel.com>

> Regards,
> Suraj Kandpal
> > Regards
> >
> > Chaitanya
> >
> > >  			return false;
> > > +		}
> > >  	}
> > >
> > >  	/* MEI/GSC interface is solid depending on which is used */
> > > --
> > > 2.25.1