[Intel-gfx] [PATCH] drm/i915/vdsc: Remove FIXME in intel_dsc_compute_config
Luca Coelho
luca at coelho.fi
Mon Jun 26 13:56:39 UTC 2023
On Mon, 2023-06-26 at 18:35 +0530, Suraj Kandpal wrote:
> Remove the FIXME and the code related to it as after verification
> it does seem the previous values were typos and no hardware spec
> mentions using these particular rc_params.
>
> Signed-off-by: Suraj Kandpal <suraj.kandpal at intel.com>
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/drm/i915/display/intel_vdsc.c
> index bd9116d2cd76..d27e84696f31 100644
> --- a/drivers/gpu/drm/i915/display/intel_vdsc.c
> +++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
> @@ -237,18 +237,6 @@ int intel_dsc_compute_params(struct intel_crtc_state *pipe_config)
>
> if (ret)
> return ret;
> -
> - /*
> - * FIXME: verify that the hardware actually needs these
> - * modifications rather than them being simple typos.
> - */
> - if (compressed_bpp == 6 &&
> - vdsc_cfg->bits_per_component == 8)
> - vdsc_cfg->rc_quant_incr_limit1 = 23;
> -
> - if (compressed_bpp == 8 &&
> - vdsc_cfg->bits_per_component == 14)
> - vdsc_cfg->rc_range_params[0].range_bpg_offset = 0;
> }
>
> /*
Reviewed-by: Luca Coelho <luciano.coelho at intel.com>
--
Cheers,
Luca.
More information about the Intel-gfx
mailing list