[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Refactor PAT/cache handling

Patchwork patchwork at emeril.freedesktop.org
Wed Jun 28 17:10:30 UTC 2023


== Series Details ==

Series: drm/i915: Refactor PAT/cache handling
URL   : https://patchwork.freedesktop.org/series/119982/
State : warning

== Summary ==

Error: dim checkpatch failed
eb5f7c604fb7 drm/i915: Refactor PAT/cache handling
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:505: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#505: FILE: drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c:63:
+i915_ttm_cache_pat(struct drm_i915_private *i915, struct ttm_resource *res,
+		     struct ttm_tt *ttm)

-:810: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#810: 
new file mode 100644

-:815: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#815: FILE: drivers/gpu/drm/i915/i915_cache.c:1:
+/*

-:816: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#816: FILE: drivers/gpu/drm/i915/i915_cache.c:2:
+ * SPDX-License-Identifier: MIT

-:894: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#894: FILE: drivers/gpu/drm/i915/i915_cache.h:15:
+#define I915_CACHE(mode) \
+	(i915_cache_t)(I915_CACHE_MODE_##mode)

-:897: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#897: FILE: drivers/gpu/drm/i915/i915_cache.h:18:
+#define _I915_CACHE(mode, flag) \
+	(i915_cache_t)((I915_CACHE_MODE_##mode) | ( BIT(8 + I915_CACHE_##flag)))

-:898: ERROR:SPACING: space prohibited after that open parenthesis '('
#898: FILE: drivers/gpu/drm/i915/i915_cache.h:19:
+	(i915_cache_t)((I915_CACHE_MODE_##mode) | ( BIT(8 + I915_CACHE_##flag)))

-:900: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#900: FILE: drivers/gpu/drm/i915/i915_cache.h:21:
+#define I915_CACHE_MODE(cache) \
+	(unsigned int)(((i915_cache_t)(cache)) & 0xff)

-:902: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#902: FILE: drivers/gpu/drm/i915/i915_cache.h:23:
+#define I915_CACHE_FLAGS(cache) \
+	(unsigned int)((((i915_cache_t)(cache) & 0xff00)) >> 16)

-:1055: WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#1055: FILE: drivers/gpu/drm/i915/i915_debugfs.c:147:
+	static const char *mode_str[] = {

-:1061: WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#1061: FILE: drivers/gpu/drm/i915/i915_debugfs.c:153:
+	static const char *flag_str[] = {

total: 5 errors, 5 warnings, 1 checks, 1319 lines checked




More information about the Intel-gfx mailing list