[Intel-gfx] [PATCH v2 3/3] drm/i915: Include timeline seqno in error capture

[Teres Alexis, Alan Previn]

On Wed, 2023-03-08 at 14:02 -0800, Teres Alexis, Alan Previn wrote:
> On Thu, 2023-02-16 at 18:24 -0800, John.C.Harrison at Intel.com wrote:
> > From: John Harrison <John.C.Harrison at Intel.com>
> > 
> > The seqno value actually written out to memory is no longer in the
> > regular HWSP. Instead, it is now in its own private timeline buffer.
> > Thus, it is no longer visible in an error capture. So, explicitly read
> > the value and include that in the capture.
> > 
> > Signed-off-by: John Harrison <John.C.Harrison at Intel.com>
> alan: snip.
> 
> simple one ... LGTM
> Reviewed-by: Alan Previn <alan.previn.teres.alexis at intel.com>

alan: i just realized i missed something. On the following hunk,
seqno printout should be using a %u format specifier since we could use the upper most bit of that 32 bit value:
Consider above a conditional RB (based on this fix) - sorry about that.

@@ -505,6 +505,7 @@  static void error_print_context(struct drm_i915_error_state_buf *m,
 		   header, ctx->comm, ctx->pid, ctx->sched_attr.priority,
 		   ctx->guilty, ctx->active,
 		   ctx->total_runtime, ctx->avg_runtime);
+	err_printf(m, "  context timeline seqno %d\n", ctx->hwsp_seqno);