[Intel-gfx] [PATCH] drm/i915/gt: Update engine_init_common documentation

Das, Nirmoy nirmoy.das at intel.com
Thu Mar 9 18:39:59 UTC 2023


On 3/9/2023 6:33 PM, Matt Roper wrote:
> On Thu, Mar 09, 2023 at 05:58:52PM +0100, Nirmoy Das wrote:
>> Change the function doc to reflect updated name.
>>
>> Cc: Andi Shyti <andi.shyti at linux.intel.com>
>> Signed-off-by: Nirmoy Das <nirmoy.das at intel.com>
>> ---
>>   drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>> index ad3413242100..83532630b639 100644
>> --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>> +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>> @@ -1429,7 +1429,7 @@ create_kernel_context(struct intel_engine_cs *engine)
>>   }
>>   
>>   /**
> Should we also un-kerneldoc this comment?  Generally we don't use
> kerneldoc comments for static functions.

Yes. I will resend replacing "/**" with "/*" .


Nirmoy

>
>
> Matt
>
>> - * intel_engines_init_common - initialize cengine state which might require hw access
>> + * engines_init_common - initialize engine state which might require hw access
>>    * @engine: Engine to initialize.
>>    *
>>    * Initializes @engine@ structure members shared between legacy and execlists
>> -- 
>> 2.39.0
>>


More information about the Intel-gfx mailing list