[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Communicate display power demands to pcode more accurately (rev3)

Patchwork patchwork at emeril.freedesktop.org
Fri Mar 17 16:46:47 UTC 2023


== Series Details ==

Series: drm/i915/display: Communicate display power demands to pcode more accurately (rev3)
URL   : https://patchwork.freedesktop.org/series/114401/
State : warning

== Summary ==

Error: dim checkpatch failed
da82682afba7 drm/i915/display: Communicate display power demands to pcode more accurately
-:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#10: 
Adding new sequence with current cdclk associate with voltage value masking.

-:83: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#83: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:2273:
+		drm_err(&i915->drm,
+				"Failed to inform PCU about display config (err %d)\n",

-:104: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'new_cdclk_state->active_pipes ==
 				 old_cdclk_state->active_pipes'
#104: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:2356:
+	if (!intel_cdclk_changed(&old_cdclk_state->actual,
+				 &new_cdclk_state->actual) &&
+				 (new_cdclk_state->active_pipes ==
+				 old_cdclk_state->active_pipes))

-:279: WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#279: FILE: drivers/gpu/drm/i915/i915_reg.h:6424:
+#define   DISPLAY_TO_PCODE_PIPE_COUNT(x)	REG_FIELD_PREP(DISPLAY_TO_PCODE_PIPE_COUNT_MASK, (x))

-:281: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#281: FILE: drivers/gpu/drm/i915/i915_reg.h:6426:
+#define   DISPLAY_TO_PCODE_UPDATE_MASK(cdclk, num_pipes, voltage_level) \
+		(DISPLAY_TO_PCODE_CDCLK(cdclk)) | \
+		(DISPLAY_TO_PCODE_PIPE_COUNT(num_pipes)) | \
+		(DISPLAY_TO_PCODE_VOLTAGE(voltage_level))

total: 1 errors, 2 warnings, 2 checks, 244 lines checked




More information about the Intel-gfx mailing list