[Intel-gfx] [PATCH] drm/i915/gt: Consider multi-gt at all places

Andi Shyti andi.shyti at linux.intel.com
Tue Mar 21 23:33:01 UTC 2023


Hi,

> > diff --git a/drivers/gpu/drm/i915/selftests/igt_live_test.h b/drivers/gpu/drm/i915/selftests/igt_live_test.h
> > index 36ed42736c52..209b0548c603 100644
> > --- a/drivers/gpu/drm/i915/selftests/igt_live_test.h
> > +++ b/drivers/gpu/drm/i915/selftests/igt_live_test.h
> > @@ -27,9 +27,9 @@ struct igt_live_test {
> >    * e.g. if the GPU was reset.
> >    */
> >   int igt_live_test_begin(struct igt_live_test *t,
> > -			struct drm_i915_private *i915,
> > +			struct intel_gt *gt,
> >   			const char *func,
> >   			const char *name);
> > -int igt_live_test_end(struct igt_live_test *t);
> > +int igt_live_test_end(struct igt_live_test *t, struct intel_gt *gt);
> 
> Back in the day the plan was that live selftests are device focused and then
> we also have intel_gt_live_subtests, which are obviously GT focused. So in
> that sense adding a single GT parameter to igt_live_test_begin isn't
> something I immediately understand.
> 
> Could you explain in one or two practical examples what is not working
> properly and how is this patch fixing it?

Tejas, would it help to split this patch in several patches?

Andi


More information about the Intel-gfx mailing list