[Intel-gfx] [PATCH 0/6] drm/i915/dpt: Fix DPT+shmem combo and add i915.enable_dpt modparam

[Ville Syrjälä]

On Wed, Mar 22, 2023 at 05:15:56PM +0200, Juha-Pekka Heikkila wrote:
> Set look all ok,
> 
> Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>

Thanks.

> 
> I guess should start to think about how to write igt tests which would 
> target directly at dpt so this kind of issues wouldn't get missed.

Yeah, I was already thinking that we should try something like
that to see if we could catch the the DPT fault bug reliably by
invoking the shrinker directly while doing stuff with DPTs.

> 
> /Juha-Pekka
> 
> On 20.3.2023 11.05, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > Avoid the shrinker evicting the DPT during hibernate and
> > causing an oops. This might also fix DPT induced display faults
> > during high memory pressure (though still don't have a real
> > theory how that could actually happen).
> > 
> > Also add a i915.enable_dpt modparam to disable DPT usage via
> > the chicken bit. This can be useful when trying to debug suspected
> > DPT issues.
> > 
> > Ville Syrjälä (6):
> >    drm/i915/dpt: Treat the DPT BO as a framebuffer
> >    drm/i915/dpt: Only do the POT stride remap when using DPT
> >    drm/i915/dpt: Introduce HAS_DPT()
> >    drm/i915: Add PLANE_CHICKEN registers
> >    drm/i915/dpt: Add a modparam to disable DPT via the chicken bit
> >    drm/i915: Move PLANE_BUG_CFG bit definitons to the correct place
> > 
> >   drivers/gpu/drm/i915/display/intel_display.c  |  6 +++++
> >   drivers/gpu/drm/i915/display/intel_dpt.c      | 23 +++++++++++++++++++
> >   drivers/gpu/drm/i915/display/intel_dpt.h      |  2 ++
> >   drivers/gpu/drm/i915/display/intel_fb.c       | 11 +++++----
> >   drivers/gpu/drm/i915/display/intel_fb.h       |  1 +
> >   .../drm/i915/display/skl_universal_plane.c    |  6 +++++
> >   drivers/gpu/drm/i915/gem/i915_gem_object.h    |  2 +-
> >   .../gpu/drm/i915/gem/i915_gem_object_types.h  |  3 +++
> >   drivers/gpu/drm/i915/i915_drv.h               |  2 ++
> >   drivers/gpu/drm/i915/i915_params.c            |  3 +++
> >   drivers/gpu/drm/i915/i915_params.h            |  1 +
> >   drivers/gpu/drm/i915/i915_reg.h               | 21 +++++++++++++----
> >   12 files changed, 70 insertions(+), 11 deletions(-)
> > 

-- 
Ville Syrjälä
Intel