[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for mtl: add support for pmdemand (rev5)

Patchwork patchwork at emeril.freedesktop.org
Fri May 12 00:31:51 UTC 2023


== Series Details ==

Series: mtl: add support for pmdemand (rev5)
URL   : https://patchwork.freedesktop.org/series/116949/
State : warning

== Summary ==

Error: dim checkpatch failed
6f074611e692 drm/i915: fix the derating percentage for MTL
25b686634b4a drm/i915: update the QGV point frequency calculations
240020f2d4ed drm/i915: store the peak bw per QGV point
2f379cefdf09 drm/i915: extract intel_bw_check_qgv_points()
97b147d865bd drm/i915: modify max_bw to return index to intel_bw_info
ffab0de08abd drm/i915/mtl: find the best QGV point for the SAGV configuration
6ef74bd7c7f9 drm/i915/mtl: Add support for PM DEMAND
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:81: WARNING:TYPO_SPELLING: 'paramters' may be misspelled - perhaps 'parameters'?
#81: FILE: drivers/gpu/drm/i915/display/intel_display.c:6969:
+	 * In D14 Pmdemand combines many paramters such as voltage index, plls,
 	                                 ^^^^^^^^^

-:109: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#109: FILE: drivers/gpu/drm/i915/display/intel_display_core.h:350:
+		struct mutex lock;

-:182: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#182: 
new file mode 100644

-:219: WARNING:LONG_LINE: line length of 119 exceeds 100 columns
#219: FILE: drivers/gpu/drm/i915/display/intel_pmdemand.c:33:
+#define to_intel_pmdemand_state(x) container_of((x) + BUILD_BUG_ON_ZERO(offsetof(struct intel_pmdemand_state, base)), \

-:597: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#597: FILE: drivers/gpu/drm/i915/display/intel_pmdemand.c:411:
+	drm_dbg_kms(&i915->drm,
+			"initate pmdemand request values: (0x%x 0x%x)\n",

-:601: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#601: FILE: drivers/gpu/drm/i915/display/intel_pmdemand.c:415:
+	intel_de_rmw(i915, XELPDP_INITIATE_PMDEMAND_REQUEST(1), 0,
+			XELPDP_PMDEMAND_REQ_ENABLE);

-:758: WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#758: FILE: drivers/gpu/drm/i915/i915_reg.h:4543:
+#define  XELPDP_PMDEMAND_QCLK_GV_BW(x)			REG_FIELD_PREP(XELPDP_PMDEMAND_QCLK_GV_BW_MASK, x)

-:760: WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#760: FILE: drivers/gpu/drm/i915/i915_reg.h:4545:
+#define  XELPDP_PMDEMAND_VOLTAGE_INDEX(x)		REG_FIELD_PREP(XELPDP_PMDEMAND_VOLTAGE_INDEX_MASK, x)

-:762: WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#762: FILE: drivers/gpu/drm/i915/i915_reg.h:4547:
+#define  XELPDP_PMDEMAND_QCLK_GV_INDEX(x)		REG_FIELD_PREP(XELPDP_PMDEMAND_QCLK_GV_INDEX_MASK, x)

-:764: WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#764: FILE: drivers/gpu/drm/i915/i915_reg.h:4549:
+#define  XELPDP_PMDEMAND_PIPES(x)			REG_FIELD_PREP(XELPDP_PMDEMAND_PIPES_MASK, x)

-:766: WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#766: FILE: drivers/gpu/drm/i915/i915_reg.h:4551:
+#define  XELPDP_PMDEMAND_DBUFS(x)			REG_FIELD_PREP(XELPDP_PMDEMAND_DBUFS_MASK, x)

-:772: WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#772: FILE: drivers/gpu/drm/i915/i915_reg.h:4557:
+#define  XELPDP_PMDEMAND_CDCLK_FREQ(x)			REG_FIELD_PREP(XELPDP_PMDEMAND_CDCLK_FREQ_MASK, x)

-:774: WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#774: FILE: drivers/gpu/drm/i915/i915_reg.h:4559:
+#define  XELPDP_PMDEMAND_DDICLK_FREQ(x)			REG_FIELD_PREP(XELPDP_PMDEMAND_DDICLK_FREQ_MASK, x)

-:776: WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#776: FILE: drivers/gpu/drm/i915/i915_reg.h:4561:
+#define  XELPDP_PMDEMAND_SCALERS(x)			REG_FIELD_PREP(XELPDP_PMDEMAND_SCALERS_MASK, x)

total: 0 errors, 11 warnings, 3 checks, 697 lines checked
5859307b239e drm/i915/display: provision to suppress drm_warn in intel_get_crtc_new_encoder




More information about the Intel-gfx mailing list