[Intel-gfx] [PATCH V2] drm/i915/gt: Add workaround 14016712196

Andi Shyti andi.shyti at linux.intel.com
Wed May 31 10:33:59 UTC 2023


Hi Tejas,

> > 
> > I'm wondering, though, if we can put both dummy pipe and real pipe in the
> > same command and advance the ring only once at the end... nevermind.
> 
> As we have conditional ring increments, we cant decide ring size at start in ring begin for whole bunch at once. Though double checking.

yes, you add it conditionally. Check, e.g., the control:

	if (!HAS_FLAT_CCS(rq->engine->i915))
		count = 8 + 4;
	else
		count = 8;

In the second if block. You are basically doing the same thing.

But I'm not strong with this.

Andi


More information about the Intel-gfx mailing list