[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Init DDI ports based on port_mask (rev3)

Patchwork patchwork at emeril.freedesktop.org
Wed May 31 19:33:42 UTC 2023


== Series Details ==

Series: drm/i915: Init DDI ports based on port_mask (rev3)
URL   : https://patchwork.freedesktop.org/series/117641/
State : warning

== Summary ==

Error: dim checkpatch failed
67cd6af1981f drm/i915: Remove bogus DDI-F from hsw/bdw output init
a501e7fc9ff2 drm/i915: Introduce device info port_mask
-:101: WARNING:LONG_LINE_COMMENT: line length of 109 exceeds 100 columns
#101: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:307:
+	.__runtime_defaults.port_mask = BIT(PORT_B) | BIT(PORT_C) | BIT(PORT_D), /* SDVO/HDMI/DP B/C, DP D */

-:108: WARNING:LONG_LINE_COMMENT: line length of 109 exceeds 100 columns
#108: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:314:
+	.__runtime_defaults.port_mask = BIT(PORT_B) | BIT(PORT_C) | BIT(PORT_D), /* SDVO/HDMI/DP B/C, DP D */

-:118: WARNING:LONG_LINE_COMMENT: line length of 133 exceeds 100 columns
#118: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:328:
+	.__runtime_defaults.port_mask = BIT(PORT_A) | BIT(PORT_B) | BIT(PORT_C) | BIT(PORT_D) /* DP A, SDVO/HDMI/DP B, HDMI/DP C/D */

-:126: WARNING:LONG_LINE_COMMENT: line length of 134 exceeds 100 columns
#126: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:350:
+	.__runtime_defaults.port_mask = BIT(PORT_A) | BIT(PORT_B) | BIT(PORT_C) | BIT(PORT_D), /* DP A, SDVO/HDMI/DP B, HDMI/DP C/D */

-:134: WARNING:LONG_LINE_COMMENT: line length of 134 exceeds 100 columns
#134: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:364:
+	.__runtime_defaults.port_mask = BIT(PORT_A) | BIT(PORT_B) | BIT(PORT_C) | BIT(PORT_D), /* DP A, SDVO/HDMI/DP B, HDMI/DP C/D */

-:150: WARNING:LONG_LINE: line length of 108 exceeds 100 columns
#150: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:397:
+	.__runtime_defaults.port_mask = BIT(PORT_A) | BIT(PORT_B) | BIT(PORT_C) | BIT(PORT_D) | BIT(PORT_E),

-:158: WARNING:LONG_LINE: line length of 108 exceeds 100 columns
#158: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:415:
+	.__runtime_defaults.port_mask = BIT(PORT_A) | BIT(PORT_B) | BIT(PORT_C) | BIT(PORT_D) | BIT(PORT_E),

-:174: WARNING:LONG_LINE: line length of 108 exceeds 100 columns
#174: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:455:
+	.__runtime_defaults.port_mask = BIT(PORT_A) | BIT(PORT_B) | BIT(PORT_C) | BIT(PORT_D) | BIT(PORT_E),

-:272: CHECK:LINE_SPACING: Please don't use multiple blank lines
#272: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:538:
 
+

-:276: WARNING:LONG_LINE: line length of 108 exceeds 100 columns
#276: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:542:
+	.__runtime_defaults.port_mask = BIT(PORT_A) | BIT(PORT_B) | BIT(PORT_C) | BIT(PORT_D) | BIT(PORT_E),

-:292: WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#292: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:598:
+		BIT(PORT_TC1) | BIT(PORT_TC2) | BIT(PORT_TC3) | BIT(PORT_TC4) | BIT(PORT_TC5) | BIT(PORT_TC5),

-:334: WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#334: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:693:
+	.__runtime_defaults.port_mask = BIT(PORT_A) | BIT(PORT_B) | BIT(PORT_C) | BIT(PORT_D_XELPD) |

total: 0 errors, 11 warnings, 1 checks, 346 lines checked
a605f4da091d drm/i915: Assert that device info bitmasks have enough bits
32ad0991d541 drm/i915: Assert that the port being initialized is valid
5e9b2a1e5aee drm/i915: Beef up SDVO/HDMI port checks
eb6a39cf08a9 drm/i915: Init DDI outputs based on port_mask on skl+
2c734eff5e3c drm/i915: Convert HSW/BDW to use port_mask for DDI probe




More information about the Intel-gfx mailing list