[Intel-gfx] [PATCH v4 00/30] drm/i915: Improve BW management on MST links

Fri Nov 3 22:43:57 UTC 2023

BTW - sorry it took me a little while to get back to this, I'm still getting
back into the swing of things but I should be able to review this next week :)

Thanks for all of the work you've done so far!

On Mon, 2023-10-30 at 17:58 +0200, Imre Deak wrote:
> This is v4 of [1] with the following changes:
> 
> - Fix a race condition between connector setup and registration
>   (added patch 1).
> - Rename DRM_DP_OVERHEAD_SSC to DRM_DP_OVERHEAD_SSC_REF_CLK
>   (Ville, patch 9).
> - Fix setting crtc_state->fec_enable, once crtc_state->port_clock
>   required for it is already set (patch 10).
> - Fix passing the correct fec_enable parameter to
>   intel_dp_bw_fec_overhead() (patch 12).
> - Fix TU size, making it match the payload size in the payload table
>   (Patch 13).
> - Apply the HBLANK expansion quirk whenever the HBLANK period is
>   300ns or less (Patch 21).
> - Fix refcounting of the DSC AUX decompression device
>   (Stan, patch 25).
> - Fix HW readout/sanitize for the connector DSC decompression enabled
>   state (patch 25).
> - Move intel_crtc_needs_modeset() check to callers of
>   clear_pipe_update_flags_on_modeset_crtc() (Ville, patch 26).
> - Fix forcing modeset on CRTC due to a change in MST topology
>   (Ville, patch 27).
> - Add missing DocBooks, fix typos.
> 
> [1] https://lore.kernel.org/all/20231024010925.3949910-1-imre.deak@intel.com
> 
> Cc: Stanislav Lisovskiy <stanislav.lisovskiy at intel.com>
> Cc: Lyude Paul <lyude at redhat.com>
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Cc: Ankit Nautiyal <ankit.k.nautiyal at intel.com>
> Cc: Arun R Murthy <arun.r.murthy at intel.com>
> 
> Imre Deak (28):
>   drm/i915/dp_mst: Fix race between connector registration and setup
>   drm/dp_mst: Add helper to determine if an MST port is downstream of
>     another port
>   drm/dp_mst: Factor out a helper to check the atomic state of a
>     topology manager
>   drm/dp_mst: Swap the order of checking root vs. non-root port BW
>     limitations
>   drm/dp_mst: Allow DSC in any Synaptics last branch device
>   drm/dp: Add DP_HBLANK_EXPANSION_CAPABLE and DSC_PASSTHROUGH_EN DPCD
>     flags
>   drm/dp_mst: Add HBLANK expansion quirk for Synaptics MST hubs
>   drm/dp: Add helpers to calculate the link BW overhead
>   drm/i915/dp_mst: Enable FEC early once it's known DSC is needed
>   drm/i915/dp: Specify the FEC overhead as an increment vs. a remainder
>   drm/i915/dp: Pass actual BW overhead to m_n calculation
>   drm/i915/dp_mst: Account for FEC and DSC overhead during BW allocation
>   drm/i915/dp_mst: Add atomic state for all streams on pre-tgl platforms
>   drm/i915/dp_mst: Program the DSC PPS SDP for each stream
>   drm/i915/dp: Make sure the DSC PPS SDP is disabled whenever DSC is
>     disabled
>   drm/i915/dp_mst: Add missing DSC compression disabling
>   drm/i915/dp: Rename intel_ddi_disable_fec_state() to
>     intel_ddi_disable_fec()
>   drm/i915/dp: Wait for FEC detected status in the sink
>   drm/i915/dp: Disable FEC ready flag in the sink
>   drm/i915/dp_mst: Handle the Synaptics HBlank expansion quirk
>   drm/i915/dp_mst: Enable decompression in the sink from the MST encoder
>     hooks
>   drm/i915/dp: Enable DSC via the connector decompression AUX
>   drm/i915/dp_mst: Enable DSC passthrough
>   drm/i915/dp_mst: Enable MST DSC decompression for all streams
>   drm/i915: Factor out function to clear pipe update flags
>   drm/i915/dp_mst: Force modeset CRTC if DSC toggling requires it
>   drm/i915/dp_mst: Improve BW sharing between MST streams
>   drm/i915/dp_mst: Check BW limitations only after all streams are
>     computed
> 
> Stanislav Lisovskiy (1):
>   drm/i915: Query compressed bpp properly using correct DPCD and DP Spec
>     info
> 
> Ville Syrjälä (1):
>   drm/dp_mst: Fix fractional DSC bpp handling
> 
>  .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |   2 +-
>  .../display/amdgpu_dm/amdgpu_dm_mst_types.c   |   2 +-
>  drivers/gpu/drm/display/drm_dp_helper.c       | 134 +++++
>  drivers/gpu/drm/display/drm_dp_mst_topology.c | 206 +++++--
>  drivers/gpu/drm/i915/display/intel_ddi.c      | 136 ++++-
>  drivers/gpu/drm/i915/display/intel_ddi.h      |   3 +
>  drivers/gpu/drm/i915/display/intel_display.c  | 101 ++--
>  drivers/gpu/drm/i915/display/intel_display.h  |   4 +-
>  .../drm/i915/display/intel_display_types.h    |   3 +
>  drivers/gpu/drm/i915/display/intel_dp.c       | 256 +++++++-
>  drivers/gpu/drm/i915/display/intel_dp.h       |  23 +-
>  drivers/gpu/drm/i915/display/intel_dp_mst.c   | 564 +++++++++++++++---
>  drivers/gpu/drm/i915/display/intel_dp_mst.h   |   5 +
>  drivers/gpu/drm/i915/display/intel_fdi.c      |   5 +-
>  drivers/gpu/drm/i915/display/intel_link_bw.c  |  16 +-
>  drivers/gpu/drm/i915/display/intel_link_bw.h  |   1 +
>  .../drm/i915/display/intel_modeset_setup.c    |   6 +
>  drivers/gpu/drm/nouveau/dispnv50/disp.c       |   3 +-
>  .../gpu/drm/tests/drm_dp_mst_helper_test.c    |   6 +-
>  include/drm/display/drm_dp.h                  |   2 +
>  include/drm/display/drm_dp_helper.h           |  18 +
>  include/drm/display/drm_dp_mst_helper.h       |   9 +-
>  22 files changed, 1270 insertions(+), 235 deletions(-)
> 

-- 
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat