[Intel-gfx] [PATCH] drm/i915/display: Remove dead code around intel_atomic_helper->free_list

Hogander, Jouni jouni.hogander at intel.com
Tue Nov 14 13:48:04 UTC 2023


On Tue, 2023-11-14 at 10:48 +0200, Ville Syrjälä wrote:
> On Fri, Nov 10, 2023 at 10:24:55AM +0200, Jouni Högander wrote:
> > After switching to directly using dma_fence instead of
> > i915_sw_fence we
> > have left some dead code around intel_atomic_helper->free_list.
> > Remove that
> > dead code.
> > 
> > Signed-off-by: Jouni Högander <jouni.hogander at intel.com>
> > ---
> >  drivers/gpu/drm/i915/display/intel_display.c  | 20 ---------------
> > ----
> >  .../gpu/drm/i915/display/intel_display_core.h |  6 ------
> >  .../drm/i915/display/intel_display_driver.c   |  7 -------
> >  3 files changed, 33 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> > b/drivers/gpu/drm/i915/display/intel_display.c
> > index 3effafcbb411..387acf21b794 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > @@ -7086,24 +7086,6 @@ static void
> > skl_commit_modeset_enables(struct intel_atomic_state *state)
> >         drm_WARN_ON(&dev_priv->drm, update_pipes);
> >  }
> >  
> > -static void intel_atomic_helper_free_state(struct drm_i915_private
> > *dev_priv)
> > -{
> > -       struct intel_atomic_state *state, *next;
> > -       struct llist_node *freed;
> > -
> > -       freed = llist_del_all(&dev_priv-
> > >display.atomic_helper.free_list);
> > -       llist_for_each_entry_safe(state, next, freed, freed)
> 
> state.freed is also dead.

Thank you for pointing this out. Please check version 2. of my patch
which is addressing this one as well.

BR,

Jouni Högander

> 



More information about the Intel-gfx mailing list