[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Implement CMRR Support (rev3)
Patchwork
patchwork at emeril.freedesktop.org
Thu Nov 16 00:54:05 UTC 2023
== Series Details ==
Series: Implement CMRR Support (rev3)
URL : https://patchwork.freedesktop.org/series/126443/
State : warning
== Summary ==
Error: dim checkpatch failed
932e33a4e513 drm/i915: Define and compute Transcoder CMRR registers
-:39: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects?
#39: FILE: drivers/gpu/drm/i915/display/intel_display.c:5077:
+#define PIPE_CONF_CHECK_LLI(name) do { \
+ if (current_config->name != pipe_config->name) { \
+ pipe_config_mismatch(fastset, crtc, __stringify(name), \
+ "(expected %lli, found %lli)", \
+ current_config->name, \
+ pipe_config->name); \
+ ret = false; \
+ } \
+} while (0)
-:39: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues
#39: FILE: drivers/gpu/drm/i915/display/intel_display.c:5077:
+#define PIPE_CONF_CHECK_LLI(name) do { \
+ if (current_config->name != pipe_config->name) { \
+ pipe_config_mismatch(fastset, crtc, __stringify(name), \
+ "(expected %lli, found %lli)", \
+ current_config->name, \
+ pipe_config->name); \
+ ret = false; \
+ } \
+} while (0)
total: 0 errors, 0 warnings, 2 checks, 119 lines checked
0d936c6d91d1 drm/i915: Add Enable/Disable for CMRR based on VRR state
-:21: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#21:
- Check pipe active state in cmrr disabling. (Similar to enable case).[Jani]
total: 0 errors, 1 warnings, 0 checks, 130 lines checked
23b739d5768b drm/i915: Compute CMRR and calculate vtotal
More information about the Intel-gfx
mailing list