[Intel-gfx] [RFC] drm: enable W=1 warnings by default across the subsystem
Javier Martinez Canillas
javierm at redhat.com
Thu Nov 30 09:59:27 UTC 2023
Jani Nikula <jani.nikula at intel.com> writes:
[...]
>
> Then I'd go for enabling in drm level and disabling individual warnings
> in the driver Makefile level if they won't get fixed.
>
>> Maybe add a Kconfig symbol for it instead of making unconditional?
>>
>> Something like:
>>
>> +# Unconditionally enable W=1 warnings locally
>> +# --- begin copy-paste W=1 warnings from scripts/Makefile.extrawarn
>> +subdir-ccflags-$(CONFIG_DRM_EXTRA_CHECKS) += -Wextra -Wunused -Wno-unused-parameter
>> ...
>
> Then we'll have a ping pong of people not using W=1 or
> CONFIG_DRM_EXTRA_CHECKS introducing warnings, and people using them
> fixing the warnings...
>
> I really do think making it unconditional is the only way.
>
Fair enough.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
More information about the Intel-gfx
mailing list