[Intel-gfx] [PATCH v2 2/2] drm: Replace drm_framebuffer plane size functions with its equivalents

[André Almeida]

On 9/26/23 16:15, Carlos Eduardo Gallo Filho wrote:
> The functions drm_framebuffer_plane_{width,height} and
> fb_plane_{width,height} do exactly the same job of its
> equivalents drm_format_info_plane_{width,height} from drm_fourcc.
>
> The only reason to have these functions on drm_framebuffer
> would be if they would added a abstraction layer to call it just
> passing a drm_framebuffer pointer and the desired plane index,
> which is not the case, where these functions actually implements
> just part of it. In the actual implementation, every call to both
> drm_framebuffer_plane_{width,height} and fb_plane_{width,height} should
> pass some drm_framebuffer attribute, which is the same as calling the
> drm_format_info_plane_{width,height} functions.
>
> The drm_format_info_pane_{width,height} functions are much more
> consistent in both its implementation and its location on code. The
> kind of calculation that they do is intrinsically derivated from the
> drm_format_info struct and has not to do with drm_framebuffer, except
> by the potential motivation described above, which is still not a good
> justification to have drm_framebuffer functions to calculate it.
>
> So, replace each drm_framebuffer_plane_{width,height} and
> fb_plane_{width,height} call to drm_format_info_plane_{width,height}
> and remove them.
>
> Signed-off-by: Carlos Eduardo Gallo Filho <gcarlos at disroot.org>
Reviewed-by: André Almeida <andrealmeid at igalia.com>