[Intel-gfx] [PATCH v2 3/4] drm/i915: add one header file for GT
Jani Nikula
jani.nikula at linux.intel.com
Mon Oct 2 07:55:40 UTC 2023
On Fri, 29 Sep 2023, Jonathan Cavitt <jonathan.cavitt at intel.com> wrote:
> From: Fei Yang <fei.yang at intel.com>
>
> Add a new header file for GT related Macros.
> Move I915_MAX_GT to this new header file because it doesn't
> belong to the i915 level.
>
> Suggested-by: Andi Shyti <andi.shyti at linux.intel.com>
> Signed-off-by: Fei Yang <fei.yang at intel.com>
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
> CC: Andi Shyti <andi.shyti at linux.intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_gt_types.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_types.h b/drivers/gpu/drm/i915/gt/intel_gt_types.h
> index def7dd0eb6f19..d697fcd7bad77 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_types.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_types.h
> @@ -23,6 +23,7 @@
> #include "i915_perf_types.h"
> #include "intel_engine_types.h"
> #include "intel_gt_buffer_pool_types.h"
> +#include "intel_gt_defines.h"
Absolutely not.
Include it where needed.
We don't want catch-all headers.
BR,
Jani.
> #include "intel_hwconfig.h"
> #include "intel_llc_types.h"
> #include "intel_reset_types.h"
--
Jani Nikula, Intel
More information about the Intel-gfx
mailing list