[Intel-gfx] [PATCH] drm/i915/ddi: Fix i2c_adapter assignment

Kandpal, Suraj suraj.kandpal at intel.com
Thu Oct 5 09:31:05 UTC 2023


> Subject: Re: [Intel-gfx] [PATCH] drm/i915/ddi: Fix i2c_adapter assignment
> 
> Hi Suraj,
> 
> On Thu, Oct 05, 2023 at 12:12:58PM +0530, Suraj Kandpal wrote:
> > i2c_adapter is being assigned using intel_connector even before the
> > NULL check occurs and even though it shouldn't be a problem lets just
> > clean this up as logically it does not make sense to check the
> > connector for NULL but dereference it before that.
> >
> > Fixes: e046d1562491 ("drm/i915/hdmi: Use connector->ddc everwhere")
> >
> > Signed-off-by: Suraj Kandpal <suraj.kandpal at intel.com>
> 
> please don't leave a blank line in the tag section. No need to resend, I guess
> whoever will merge this patch can fix it before pushing.
> 

Hi Andi,
Thanks for the review ! will keep this in mind in future

Regards,
Suraj Kandpal

> Reviewed-by: Andi Shyti <andi.shyti at linux.intel.com>
> 
> Andi


More information about the Intel-gfx mailing list