[Intel-gfx] [PATCH] drm/i915/ddi: Remove redundant intel_connector NULL check

[Andi Shyti]

Hi,

On Thu, Oct 05, 2023 at 04:40:41PM +0530, Suraj Kandpal wrote:
> Remove redundant intel_connector NULL check. Having it here just
> creates further confusion and also the variable already gets
> dereferenced before the aforementioned NULL check
> 
> Fixes: dba14b27dd3c ("drm/i915: Reinitialize sink scrambling/TMDS clock ratio on HPD")

You don't need the Fixes tag here anymore, as this is not fixing
anything.

> Signed-off-by: Suraj Kandpal <suraj.kandpal at intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index 4668de45d6fe..9151d5add960 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -4333,7 +4333,7 @@ static int intel_hdmi_reset_link(struct intel_encoder *encoder,
>  	u8 config;
>  	int ret;
>  
> -	if (!connector || connector->base.status != connector_status_connected)
> +	if (connector->base.status != connector_status_connected)

based on Jani's and Ville's previous review, looks OK.

Reviewed-by: Andi Shyti <andi.shyti at linux.intel.com> 

Andi

>  		return 0;
>  
>  	ret = drm_modeset_lock(&dev_priv->drm.mode_config.connection_mutex,
> -- 
> 2.25.1