[Intel-gfx] [PATCH dii-client v6 2/5] drm/i915: Define and use GuC and CTB TLB invalidation routines

[Andi Shyti]

Hi Jonathan,

> -	if (intel_uc_wants_guc(&ggtt->vm.gt->uc))
> +	if (intel_uc_wants_guc_submission(&ggtt->vm.gt->uc))

I think the failures we see in CI come from here. I think you had
it right the first time, this should have both the checks:

	if (intel_uc_wants_guc(&ggtt->vm.gt->uc) &&
	    intel_uc_wants_guc_submission(&ggtt->vm.gt->uc))

The first is checking whether GuC is enabled, the second is
checking if the submission is enabled.

AFAU, running through the net of
is_supported/wanted/enabled/disabled/gone/awol/onholiday/chillingout/.../
there is a distinction between supported and enabled. The
condition for GuC submission to be enabled is to have GuC
supported, but not necessarily enabled.

So answering Tvrtko's question: No,
intel_uc_wants_guc_submission() does not imply
intel_uc_wants_guc().

Question to GuC experts... should it be?

Andi