[Intel-gfx] [PATCH 1/2] drm/i915: drop -Wall and related disables from cflags as redundant

[Jani Nikula]

On Tue, 10 Oct 2023, Nick Desaulniers <ndesaulniers at google.com> wrote:
> On Tue, Oct 10, 2023 at 1:50 AM Jani Nikula <jani.nikula at intel.com> wrote:
>> This is the simplest I could think of:
>>
>> # The following turn off the warnings enabled by -Wextra
>> ifeq ($(findstring 2, $(KBUILD_EXTRA_WARN)),)
>> KBUILD_CFLAGS += -Wno-missing-field-initializers
>> KBUILD_CFLAGS += -Wno-type-limits
>> KBUILD_CFLAGS += -Wno-shift-negative-value
>> endif
>> ifeq ($(findstring 3, $(KBUILD_EXTRA_WARN)),)
>> KBUILD_CFLAGS += -Wno-sign-compare
>> endif
>>
>> Masahiro, I'd like to get your feedback on which to choose,
>> unconditionally silencing the W=2/W=3 warnings for i915, or looking at
>> KBUILD_EXTRA_WARN.
>
> KBUILD_EXTRA_WARN looks better to me; otherwise they would be hidden
> forever (or nearly).  Suffer some duplication, w/e.

Thanks, sent v2 with this [1].

BR,
Jani.

[1] https://lore.kernel.org/r/cover.1697009258.git.jani.nikula@intel.com

-- 
Jani Nikula, Intel