[Intel-gfx] [PATCH 00/25] Framework for display parameters

[Jani Nikula]

On Tue, 10 Oct 2023, Jouni Högander <jouni.hogander at intel.com> wrote:
> Currently all module parameters are handled by i915_param.c/h. This
> is a problem for display parameters when Xe driver is used.
>
> This patch set adds a mechanism to add parameters specific to the
> display. This is mainly copied from existing i915 parameters
> implementation with some naming changes and taking into account
> varying driver name.
>
> Also all display specific module parameters are moved under display and the
> module parameter are all converted as non-writable. This should be ok
> as we have writable device parameters under debugfs.

I did not do a detailed review, but quickly glanced through the series,
and I think the approach is fine.

Acked-by: Jani Nikula <jani.nikula at intel.com>

But needs a detailed review.

>
> Cc: Jani Nikula <jani.nikula at intel.com>
> Cc: Uma Shankar <uma.shankar at intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
>
> Jouni Högander (25):
>   drm/i915/display: Add framework to add parameters specific to display
>   drm/i915/display: Dump also display parameters into GPU error dump
>   drm/i915/display: Move enable_fbc module parameter under display
>   drm/i915/display: Move psr related module parameters under display
>   drm/i915/display: Move vbt_firmware module parameter under display
>   drm/i915/display: Move lvds_channel_mode module parameter under
>     display
>   drm/i915/display: Move panel_use_ssc module parameter under display
>   drm/i915/display: Move vbt_sdvo_panel_type module parameter under
>     display
>   drm/i915/display: Move enable_dc module parameter under display
>   drm/i915/display: Move enable_dpt module parameter under display
>   drm/i915/display: Move enable_sagv module parameter under display
>   drm/i915/display: Move disable_power_well module parameter under
>     display
>   drm/i915/display: Move enable_ips module parameter under display
>   drm/i915/display: Move invert_brightness module parameter under
>     display
>   drm/i915/display: Move edp_vswing module parameter under display
>   drm/i915/display: Move fastboot module parameter under display
>   drm/i915/display: Move enable_dpcd_backlightmodule parameter under
>     display
>   drm/i915/display: Move load_detect_test parameter under display
>   drm/i915/display: Move force_reset_modeset_test parameter under
>     display
>   drm/i915/display: Move disable_display parameter under display
>   drm/i915/display: Use device parameters instead of module in
>     I915_STATE_WARN
>   drm/i915/display: Move verbose_state_checks under display
>   drm/i915/display: Move nuclear_pageflip under display
>   drm/i915/display: Move enable_dp_mst under display
>   drm/i915/display: Use same permissions for enable_sagv as for rest
>
>  drivers/gpu/drm/i915/Makefile                 |   2 +
>  drivers/gpu/drm/i915/display/hsw_ips.c        |   4 +-
>  drivers/gpu/drm/i915/display/i9xx_wm.c        |   2 +-
>  .../gpu/drm/i915/display/intel_backlight.c    |   9 +-
>  drivers/gpu/drm/i915/display/intel_bios.c     |   6 +-
>  drivers/gpu/drm/i915/display/intel_crt.c      |   4 +-
>  drivers/gpu/drm/i915/display/intel_display.c  |   4 +-
>  drivers/gpu/drm/i915/display/intel_display.h  |   2 +-
>  .../gpu/drm/i915/display/intel_display_core.h |   2 +
>  .../drm/i915/display/intel_display_debugfs.c  |   2 +
>  .../display/intel_display_debugfs_params.c    | 176 ++++++++++++++
>  .../display/intel_display_debugfs_params.h    |  14 ++
>  .../drm/i915/display/intel_display_device.c   |  13 +-
>  .../drm/i915/display/intel_display_device.h   |   1 +
>  .../drm/i915/display/intel_display_params.c   | 221 ++++++++++++++++++
>  .../drm/i915/display/intel_display_params.h   |  62 +++++
>  .../drm/i915/display/intel_display_power.c    |  14 +-
>  .../drm/i915/display/intel_display_reset.c    |   2 +-
>  drivers/gpu/drm/i915/display/intel_dp.c       |   6 +-
>  .../drm/i915/display/intel_dp_aux_backlight.c |   4 +-
>  drivers/gpu/drm/i915/display/intel_dpt.c      |   6 +-
>  drivers/gpu/drm/i915/display/intel_fb.c       |   2 +-
>  drivers/gpu/drm/i915/display/intel_fbc.c      |  10 +-
>  drivers/gpu/drm/i915/display/intel_lvds.c     |   4 +-
>  drivers/gpu/drm/i915/display/intel_opregion.c |   2 +-
>  drivers/gpu/drm/i915/display/intel_panel.c    |   4 +-
>  drivers/gpu/drm/i915/display/intel_psr.c      |  14 +-
>  .../drm/i915/display/skl_universal_plane.c    |   2 +-
>  drivers/gpu/drm/i915/display/skl_watermark.c  |   5 +-
>  drivers/gpu/drm/i915/i915_driver.c            |   2 +
>  drivers/gpu/drm/i915/i915_gpu_error.c         |   3 +
>  drivers/gpu/drm/i915/i915_gpu_error.h         |   2 +
>  drivers/gpu/drm/i915/i915_params.c            |  94 --------
>  drivers/gpu/drm/i915/i915_params.h            |  23 --
>  34 files changed, 553 insertions(+), 170 deletions(-)
>  create mode 100644 drivers/gpu/drm/i915/display/intel_display_debugfs_params.c
>  create mode 100644 drivers/gpu/drm/i915/display/intel_display_debugfs_params.h
>  create mode 100644 drivers/gpu/drm/i915/display/intel_display_params.c
>  create mode 100644 drivers/gpu/drm/i915/display/intel_display_params.h

-- 
Jani Nikula, Intel