[Intel-gfx] [PATCH v2] drm/i915: Flush WC GGTT only on required platforms

Nirmoy Das nirmoy.das at intel.com
Mon Oct 16 07:47:43 UTC 2023


Hi Andi,

On 10/14/2023 10:51 AM, Andi Shyti wrote:
> Hi Nirmoy,
>
> On Fri, Oct 13, 2023 at 03:44:39PM +0200, Nirmoy Das wrote:
>> gen8_ggtt_invalidate() is only needed for limited set of platforms
>> where GGTT is mapped as WC otherwise this can cause unwanted
>> side-effects on XE_HP platforms where GFX_FLSH_CNTL_GEN6 is not
>> valid.
>>
>> v2: Add a func to detect wc ggtt detection (Ville)
>>
>> Fixes: d2eae8e98d59 ("drm/i915/dg2: Drop force_probe requirement")
>> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>
>> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
>> Cc: Jani Nikula <jani.nikula at linux.intel.com>
>> Cc: Jonathan Cavitt <jonathan.cavitt at intel.com>
>> Cc: John Harrison <john.c.harrison at intel.com>
>> Cc: Andi Shyti <andi.shyti at linux.intel.com>
>> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
>> Cc: <stable at vger.kernel.org> # v6.2+
>> Suggested-by: Matt Roper <matthew.d.roper at intel.com>
>> Signed-off-by: Nirmoy Das <nirmoy.das at intel.com>
>> Acked-by: Andi Shyti <andi.shyti at linux.intel.com>
> I took some time to look at this and you can swap the a-b with
> an r-b:
>
> Reviewed-by: Andi Shyti <andi.shyti at linux.intel.com>

Thanks! Going to resend one more rev with commit that is started using 
this register for WC mapping.


Regards,

Nirmoy

>
> Thanks,
> Andi


More information about the Intel-gfx mailing list