[Intel-gfx] [PATCH v1 1/2] drm/i915/display: display device info debugfs entry

[Borah, Chaitanya Kumar]

Hello Vinod,

> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces at lists.freedesktop.org> On Behalf Of Vinod
> Govindapillai
> Sent: Tuesday, October 17, 2023 1:25 PM
> To: intel-gfx at lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH v1 1/2] drm/i915/display: display device info
> debugfs entry
> 
> Have a common debugfs entry to get the display device info for both xe and
> i915 drivers.
> 
> Signed-off-by: Vinod Govindapillai <vinod.govindapillai at intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display_debugfs.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index fbe75d47a165..ed83339f50f0 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -641,6 +641,16 @@ static int i915_display_info(struct seq_file *m, void
> *unused)
>  	return 0;
>  }
> 
> +static int i915_display_device_info(struct seq_file *m, void *unused) {
> +	struct drm_i915_private *i915 = node_to_i915(m->private);
> +	struct drm_printer p = drm_seq_file_printer(m);
> +
> +	intel_display_device_info_print(DISPLAY_INFO(i915),
> +DISPLAY_RUNTIME_INFO(i915), &p);
> +
> +	return 0;
> +}
> +
>  static int i915_shared_dplls_info(struct seq_file *m, void *unused)  {
>  	struct drm_i915_private *dev_priv = node_to_i915(m->private); @@
> -1059,6 +1069,7 @@ static const struct drm_info_list
> intel_display_debugfs_list[] = {
>  	{"i915_gem_framebuffer", i915_gem_framebuffer_info, 0},
>  	{"i915_power_domain_info", i915_power_domain_info, 0},
>  	{"i915_display_info", i915_display_info, 0},
> +	{"i915_display_device_info", i915_display_device_info, 0},

Nit: Perhaps we can name it " i915_display_capabilities" keeping the essence of the original debugfs entry.

Regards

Chaitanya

>  	{"i915_shared_dplls_info", i915_shared_dplls_info, 0},
>  	{"i915_dp_mst_info", i915_dp_mst_info, 0},
>  	{"i915_ddb_info", i915_ddb_info, 0},
> --
> 2.34.1