[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for fix DRM_USE_DYNAMIC_DEBUG=y regression (rev4)

Patchwork patchwork at emeril.freedesktop.org
Wed Oct 18 23:59:07 UTC 2023


== Series Details ==

Series: fix DRM_USE_DYNAMIC_DEBUG=y regression (rev4)
URL   : https://patchwork.freedesktop.org/series/125063/
State : warning

== Summary ==

Error: dim checkpatch failed
de473fa889bf test-dyndbg: fixup CLASSMAP usage error
6120b244541c dyndbg: reword "class unknown, " to "class:_UNKNOWN_"
f126f978b435 dyndbg: make ddebug_class_param union members same size
aae94727a713 dyndbg: replace classmap list with a vector
66b5f39c8785 dyndbg: ddebug_apply_class_bitmap - add module arg, select on it
1cdfc9d903fc dyndbg: split param_set_dyndbg_classes to module/wrapper fns
fc06b7feccfe dyndbg: drop NUM_TYPE_ARRAY
ffcb9f1f8636 dyndbg: reduce verbose/debug clutter
c866a539e406 dyndbg: silence debugs with no-change updates
4784ef035287 dyndbg: tighten ddebug_class_name() 1st arg type
3ac7b8d72fd2 dyndbg: tighten fn-sig of ddebug_apply_class_bitmap
1da13b10463b dyndbg: reduce verbose=3 messages in ddebug_add_module
74131b274a45 dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code
43de21a56b00 dyndbg-API: fix CONFIG_DRM_USE_DYNAMIC_DEBUG regression
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:451: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_var' - possible side-effects?
#451: FILE: include/linux/dynamic_debug.h:121:
+#define DYNDBG_CLASSMAP_USE_(_var, _uname)				\
+	extern struct ddebug_class_map _var;				\
+	static struct ddebug_class_user __aligned(8) __used		\
+	__section("__dyndbg_class_users") _uname = {			\
+		.user_mod_name = KBUILD_MODNAME,			\
+		.map = &_var,						\
 	}

-:771: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#771: FILE: lib/dynamic_debug.c:1254:
+	for (i = 0, cli = di->class_users; i < di->num_class_users; i++, cli++) {
+

-:776: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#776: FILE: lib/dynamic_debug.c:1259:
+		if (!strcmp(cli->user_mod_name, dt->mod_name)) {
+

-:877: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'base' may be better as '(base)' to avoid precedence issues
#877: FILE: lib/test_dynamic_debug.c:36:
+#define CLASSMAP_BITMASK(width, base) (((1UL << (width)) - 1) << base)

-:992: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#992: 
new file mode 100644

total: 0 errors, 1 warnings, 4 checks, 738 lines checked
a01f9dca7c9a dyndbg: refactor ddebug_classparam_clamp_input
d22b3571321b dyndbg-API: promote DYNDBG_CLASSMAP_PARAM to API
22dd04f68f6a dyndbg-doc: add classmap info to howto
bba3fca7dc81 dyndbg: reserve flag bit _DPRINTK_FLAGS_PREFIX_CACHED
-:30: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#30: FILE: include/linux/dynamic_debug.h:41:
+#define _DPRINTK_FLAGS_PREFIX_CACHED	(1<<7)
                                     	  ^

total: 0 errors, 0 warnings, 1 checks, 7 lines checked
5de650a517eb dyndbg: add _DPRINTK_FLAGS_INCL_LOOKUP
16edd46daddc dyndbg: refactor *dynamic_emit_prefix
3be6bca84bf4 dyndbg: change WARN_ON to WARN_ON_ONCE
fdb1745e66b1 drm: use correct ccflags-y spelling
57081bf5f017 drm-drivers: DRM_CLASSMAP_USE in 2nd batch of drivers, helpers
4f5d83495dc0 drm: restore CONFIG_DRM_USE_DYNAMIC_DEBUG un-BROKEN




More information about the Intel-gfx mailing list