[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for DRM scheduling cgroup controller (rev5)

Patchwork patchwork at emeril.freedesktop.org
Wed Oct 25 04:29:59 UTC 2023


== Series Details ==

Series: DRM scheduling cgroup controller (rev5)
URL   : https://patchwork.freedesktop.org/series/109902/
State : warning

== Summary ==

Error: dim checkpatch failed
cc8efaeef096 cgroup: Add the DRM cgroup controller
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:11: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#11: 
new file mode 100644

-:74: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'kernel/cgroup/drm.c', please use '//' instead
#74: FILE: kernel/cgroup/drm.c:1:
+/* SPDX-License-Identifier: MIT */

-:74: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#74: FILE: kernel/cgroup/drm.c:1:
+/* SPDX-License-Identifier: MIT */

total: 0 errors, 3 warnings, 0 checks, 97 lines checked
9c250079a63b drm/cgroup: Track DRM clients per cgroup
3604a66e26c3 drm/cgroup: Add ability to query drm cgroup GPU time
-:34: WARNING:SPACING: Unnecessary space before function pointer arguments
#34: FILE: include/drm/drm_drv.h:175:
+	u64 (*active_time_us) (struct drm_file *);

-:34: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct drm_file *' should also have an identifier name
#34: FILE: include/drm/drm_drv.h:175:
+	u64 (*active_time_us) (struct drm_file *);

total: 0 errors, 2 warnings, 0 checks, 72 lines checked
d54ecc03659c drm/cgroup: Add over budget signalling callback
-:26: WARNING:SPACING: Unnecessary space before function pointer arguments
#26: FILE: include/drm/drm_drv.h:183:
+	int (*signal_budget) (struct drm_file *, u64 used, u64 budget);

-:26: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct drm_file *' should also have an identifier name
#26: FILE: include/drm/drm_drv.h:183:
+	int (*signal_budget) (struct drm_file *, u64 used, u64 budget);

total: 0 errors, 2 warnings, 0 checks, 36 lines checked
0c7a175c3ee9 drm/cgroup: Only track clients which are providing drm_cgroup_ops
872f8b2b6289 cgroup/drm: Introduce weight based drm cgroup control
-:53: WARNING:TYPO_SPELLING: 'heterogenous' may be misspelled - perhaps 'heterogeneous'?
#53: FILE: Documentation/admin-guide/cgroup-v2.rst:2433:
+Because of the heterogenous hardware and driver DRM capabilities, time control
                ^^^^^^^^^^^^

total: 0 errors, 1 warnings, 0 checks, 530 lines checked
60e88112f662 drm/i915: Implement cgroup controller over budget throttling
b8997acc9c0c cgroup/drm: Expose GPU utilisation




More information about the Intel-gfx mailing list