[Intel-gfx] [PATCH] drm/i915/mtl: Apply notify_guc to all GTs

[Nirmoy Das]

On 10/31/2023 11:57 AM, Nirmoy Das wrote:
> merged to drm-next

Sorry, drm-intel-next not drm-next.


Regards,

Nirmoy

>
>
> Thanks,
>
> Nirmoy
>
> On 10/25/2023 3:12 PM, Andrzej Hajda wrote:
>>
>>
>> On 25.10.2023 12:28, Nirmoy Das wrote:
>>> Handle platforms with multiple GTs by iterate over all GTs.
>>> Add a Fixes commit so this gets propagated for MTL support.
>>>
>>> Fixes: 213c43676beb ("drm/i915/mtl: Remove the 'force_probe' 
>>> requirement for Meteor Lake")
>>> Suggested-by: John Harrison <john.c.harrison at intel.com>
>>> Cc: Jani Nikula <jani.nikula at linux.intel.com>
>>> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
>>> Cc: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>
>>> Cc: Andi Shyti <andi.shyti at linux.intel.com>
>>> Cc: Andrzej Hajda <andrzej.hajda at intel.com>
>>> Signed-off-by: Nirmoy Das <nirmoy.das at intel.com>
>>> ---
>>>   drivers/gpu/drm/i915/i915_debugfs_params.c | 9 ++++++---
>>>   1 file changed, 6 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/i915_debugfs_params.c 
>>> b/drivers/gpu/drm/i915/i915_debugfs_params.c
>>> index 614bde321589..8bca02025e09 100644
>>> --- a/drivers/gpu/drm/i915/i915_debugfs_params.c
>>> +++ b/drivers/gpu/drm/i915/i915_debugfs_params.c
>>> @@ -38,10 +38,13 @@ static int i915_param_int_open(struct inode 
>>> *inode, struct file *file)
>>>     static int notify_guc(struct drm_i915_private *i915)
>>>   {
>>> -    int ret = 0;
>>> +    struct intel_gt *gt;
>>> +    int i, ret = 0;
>>>   -    if (intel_uc_uses_guc_submission(&to_gt(i915)->uc))
>>> -        ret = intel_guc_global_policies_update(&to_gt(i915)->uc.guc);
>>> +    for_each_gt(gt, i915, i) {
>>> +        if (intel_uc_uses_guc_submission(&gt->uc))
>>> +            ret = intel_guc_global_policies_update(&gt->uc.guc);
>>> +    }
>>
>> Reviewed-by: Andrzej Hajda <andrzej.hajda at intel.com>
>>
>> Regards
>> Andrzej
>>
>>>         return ret;
>>>   }
>>