[Intel-gfx] [PATCH 3/4] drm/i915/display: Extract display workarounds from clock gating init

Lucas De Marchi lucas.demarchi at intel.com
Fri Sep 8 21:51:16 UTC 2023


On Wed, Sep 06, 2023 at 04:47:36PM -0700, Matt Roper wrote:
>Several of the register updates that are currently done in the clock
>gating init functions are actually display workarounds that should move
>into the display-specific part of the code.  Furthermore, some of the
>registers being programmed don't even have anything to do with clock
>gating at all.
>
>Extract the display workarounds for gen11 and later platforms to a
>dedicated display/intel_display_wa.c file to keep these separate from
>the SOC / sgunit clock gating that we need on some platforms.  The gen11
>cutoff here is selected somewhat arbitrarily; this is the point where
>workarounds were first assigned dedicated lineage numbers that can be
>easily looked up and confirmed in the modern workaround database.  It
>also avoids any confusion on older platforms where the exact boundaries
>between display/GT/other IP blocks wasn't as well-defined as it is
>today.
>
>Signed-off-by: Matt Roper <matthew.d.roper at intel.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi


More information about the Intel-gfx mailing list