[Intel-gfx] [PATCH v3] drm/i915/pxp: Add drm_dbgs for critical PXP events.

Teres Alexis, Alan Previn alan.previn.teres.alexis at intel.com
Fri Sep 15 20:25:45 UTC 2023


On Fri, 2023-09-15 at 13:15 -0700, Teres Alexis, Alan Previn wrote:
> Debugging PXP issues can't even begin without understanding precedding
> sequence of important events. Add drm_dbg into the most important PXP events.
> 
>  v3 : - move gt_dbg to after mutex block in function
>         i915_gsc_proxy_component_bind. (Vivaik)
>  v2 : - remove __func__ since drm_dbg covers that (Jani).
>       - add timeout dbg of the restart from front-end (Alan).
> 
alan:snip

> +++ b/drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c
> @@ -322,6 +322,7 @@ static int i915_gsc_proxy_component_bind(struct device *i915_kdev,
>  	gsc->proxy.component = data;
>  	gsc->proxy.component->mei_dev = mei_kdev;
>  	mutex_unlock(&gsc->proxy.mutex);
> +	gt_dbg(gt, "GSC proxy mei component bound\n");

forgot to include RB from Vivaik, per condition of fixing above hunk, from rev2 dri-devel https://lists.freedesktop.org/archives/dri-devel/2023-September/422858.html :

Reviewed-by: Balasubrawmanian, Vivaik <vivaik.balasubrawmanian at intel.com> 


More information about the Intel-gfx mailing list