[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,01/22] drm/i915/xelpdp: Add XE_LPDP_FEATURES (rev2)

Patchwork patchwork at emeril.freedesktop.org
Wed Sep 20 16:03:12 UTC 2023


== Series Details ==

Series: series starting with [CI,01/22] drm/i915/xelpdp: Add XE_LPDP_FEATURES (rev2)
URL   : https://patchwork.freedesktop.org/series/123938/
State : warning

== Summary ==

Error: dim checkpatch failed
90dd23f88c0a drm/i915/xelpdp: Add XE_LPDP_FEATURES
6330ee8e7216 drm/i915/lnl: Add display definitions
0df6b8dcc3bf drm/i915/xe2lpd: FBC is now supported on all pipes
47267c23e382 drm/i915/display: Remove FBC capability from fused off pipes
d2ab081dee5a drm/i915: Re-order if/else ladder in intel_detect_pch()
480cd983fb8a drm/i915/xe2lpd: Add fake PCH
9602282160c1 drm/i915/xe2lpd: Treat cursor plane as regular plane for DDB allocation
a6ddc8ff7c0b drm/i915/xe2lpd: Don't try to program PLANE_AUX_DIST
0aff2fb11f61 drm/i915/xe2lpd: Register DE_RRMR has been removed
89e5b5e66657 drm/i915/display: Fix style and conventions for DP AUX regs
929f8df603c8 drm/i915/display: Use _PICK_EVEN_2RANGES() in DP AUX regs
36459779ccd3 drm/i915/xe2lpd: Re-order DP AUX regs
-:88: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'aux_ch' - possible side-effects?
#88: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_regs.h:21:
+#define __xe2lpd_aux_ch_idx(aux_ch)						\
+	(aux_ch >= AUX_CH_USBC1 ? aux_ch : AUX_CH_USBC4 + 1 + aux_ch - AUX_CH_A)

-:88: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'aux_ch' may be better as '(aux_ch)' to avoid precedence issues
#88: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_regs.h:21:
+#define __xe2lpd_aux_ch_idx(aux_ch)						\
+	(aux_ch >= AUX_CH_USBC1 ? aux_ch : AUX_CH_USBC4 + 1 + aux_ch - AUX_CH_A)

-:104: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'aux_ch' - possible side-effects?
#104: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_regs.h:36:
+#define XELPDP_DP_AUX_CH_CTL(i915__, aux_ch)					\
+		(DISPLAY_VER(i915__) >= 20 ?					\
+		 _XELPDP_DP_AUX_CH_CTL(__xe2lpd_aux_ch_idx(aux_ch)) :		\
+		 _XELPDP_DP_AUX_CH_CTL(aux_ch))

-:121: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'aux_ch' - possible side-effects?
#121: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_regs.h:84:
+#define XELPDP_DP_AUX_CH_DATA(i915__, aux_ch, i)				\
+		(DISPLAY_VER(i915__) >= 20 ?					\
+		 _XELPDP_DP_AUX_CH_DATA(__xe2lpd_aux_ch_idx(aux_ch), i) :	\
+		 _XELPDP_DP_AUX_CH_DATA(aux_ch, i))

-:121: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects?
#121: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_regs.h:84:
+#define XELPDP_DP_AUX_CH_DATA(i915__, aux_ch, i)				\
+		(DISPLAY_VER(i915__) >= 20 ?					\
+		 _XELPDP_DP_AUX_CH_DATA(__xe2lpd_aux_ch_idx(aux_ch), i) :	\
+		 _XELPDP_DP_AUX_CH_DATA(aux_ch, i))

total: 0 errors, 0 warnings, 5 checks, 92 lines checked
12dd53590a4e drm/i915/xe2lpd: Handle port AUX interrupts
986a5dc94cca drm/i915/xe2lpd: Read pin assignment from IOM
24cd21516592 drm/i915/xe2lpd: Enable odd size and panning for planar yuv
042f79b6681a drm/i915/xe2lpd: Add support for HPD
5a8fc38360d2 drm/i915/xe2lpd: Extend Wa_15010685871
1121ecaac4c2 drm/i915/lnl: Add gmbus/ddc support
713e5b5d6d95 drm/i915/lnl: Add CDCLK table
0dc346291447 drm/i915/xe2lpd: Add display power well
-:13: WARNING:TYPO_SPELLING: 'regiser' may be misspelled - perhaps 'register'?
#13: 
v2: Do not rmw as bit 31 is the only R/W bit in the regiser (Matt Roper)
                                                    ^^^^^^^

total: 0 errors, 1 warnings, 0 checks, 113 lines checked
93d7ec0cdc80 drm/i915/xe2lpd: Add DC state support
-:41: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#41: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1565:
+I915_DECL_PW_DOMAINS(xe2lpd_pwdoms_dc_off,
+	POWER_DOMAIN_DC_OFF,

-:49: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#49: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1573:
+		.instances = &I915_PW_INSTANCES(

total: 0 errors, 0 warnings, 2 checks, 37 lines checked
57f5a13b3728 drm/i915/lnl: Start using CDCLK through PLL




More information about the Intel-gfx mailing list