[Intel-gfx] [PATCH] drm/i915/gt: remove a static inline that requires including i915_drv.h

Andi Shyti andi.shyti at linux.intel.com
Thu Sep 21 17:22:08 UTC 2023


Hi Jani,

On Thu, Sep 21, 2023 at 07:24:56PM +0300, Jani Nikula wrote:
> It's actively harmful to add static inlines in headers that require you
> to pull in more headers. Remove the include added in commit f1530f912ed8
> ("drm/i915/gt: Apply workaround 22016122933 correctly"). We see that
> there's already an implicit dependency on the i915_drv.h that we need to
> address too.
> 
> Cc: Andi Shyti <andi.shyti at linux.intel.com>
> Cc: Fei Yang <fei.yang at intel.com>
> Cc: Jonathan Cavitt <jonathan.cavitt at intel.com>
> Cc: Matt Roper <matthew.d.roper at intel.com>
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>

Reviewed-by: Andi Shyti <andi.shyti at linux.intel.com> 

Andi


More information about the Intel-gfx mailing list