[Intel-gfx] [PATCH] drm/i915/gem: Make i915_gem_shrinker multi-gt aware

Andi Shyti andi.shyti at linux.intel.com
Mon Sep 25 15:24:30 UTC 2023


Hi Jani,

> >>  	struct i915_vma *vma, *next;
> >>  	unsigned long freed_pages = 0;
> >>  	intel_wakeref_t wakeref;
> >> +	struct intel_gt *gt;
> >> +	int i;
> >
> > the trend is to use 'unsigned int' here and I've seen it
> > reviewed. Personally, if I really have to express a preference, I
> > prefer 'int' because it's a bit safer, generally I don't really
> > mind :)
> 
> Always use int over unsigned int if you don't have a specific reason not
> to. ("It can't be negative" is not a good reason.)

Finally someone! I totally agree!

Andi


More information about the Intel-gfx mailing list