[Intel-gfx] [PATCH 2/2] drm/i915: Add missing GSCCS documentation

[Matt Roper]

On Tue, Sep 26, 2023 at 12:51:07PM -0400, Rodrigo Vivi wrote:
> Introduce the basic documentation about GSC CS.
> 
> This "GPU Basics" section is focused on explaining the hardware
> rather than the driver/uapi, so let's make sure GSC is also]

Stray "]"

> properly documented here.
> 
> Fixes: 5fd974d164b4 ("drm/i915/mtl: add initial definitions for GSC CS")
> Suggested-by: Matt Roper <matthew.d.roper at intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> ---
>  Documentation/gpu/i915.rst | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu/i915.rst
> index 13de8bcaaa29..893ced66646a 100644
> --- a/Documentation/gpu/i915.rst
> +++ b/Documentation/gpu/i915.rst
> @@ -279,6 +279,10 @@ An Intel GPU has multiple engines. There are several engine types:
>    Also sometimes called 'VEBOX' in hardware documentation.
>  - Compute Command Streamer (CCS). An engine that has access to the media and
>    GPGPU pipelines, but not the 3D pipeline.
> +- Graphics System Controller (GSCCS). A dedicated engine for internal

Isn't the "S" for "Security" rather than "System?"  E.g., bspec 62358.

> +  communication with GSC controller on security related tasks like
> +  High-bandwidth Digital Content Protection (HDCP), Protected Xe Path (PXP),
> +  and HuC firmware authentitcation.

Typo: s/authentitcation/authentication/


Matt

>  
>  The Intel GPU family is a family of integrated GPU's using Unified
>  Memory Access. For having the GPU "do work", user space will feed the
> -- 
> 2.41.0
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation