[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/4] drm/i915: Define and use GuC and CTB TLB invalidation routines

Patchwork patchwork at emeril.freedesktop.org
Fri Sep 29 21:32:22 UTC 2023


== Series Details ==

Series: series starting with [v2,1/4] drm/i915: Define and use GuC and CTB TLB invalidation routines
URL   : https://patchwork.freedesktop.org/series/124472/
State : warning

== Summary ==

Error: dim checkpatch failed
11e3929526f1 drm/i915: Define and use GuC and CTB TLB invalidation routines
-:246: WARNING:LINE_SPACING: Missing a blank line after declarations
#246: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:1196:
+		int ret = intel_guc_tlb_invalidation_done(ct_to_guc(ct), hxg, request->size);
+		ct_free_msg(request);

-:336: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#336: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:1995:
+		GEM_BUG_ON(wait->status);

-:465: WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#465: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:4762:
+			REG_FIELD_PREP(INTEL_GUC_TLB_INVAL_MODE_MASK, INTEL_GUC_TLB_INVAL_MODE_HEAVY) |

-:501: WARNING:BRACES: braces {} are not necessary for single statement blocks
#501: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:4798:
+	if (err) {
+		goto out;
+	}

-:537: CHECK:LINE_SPACING: Please don't use multiple blank lines
#537: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:4834:
+
+

total: 0 errors, 4 warnings, 1 checks, 460 lines checked
2af442b6cac6 drm/i915: No TLB invalidation on wedged or suspended GT
9f3951ca96dc drm/i915: add one header file for GT
152c85bedcbb drm/i915: Invalidate the TLBs on each GT




More information about the Intel-gfx mailing list