[PATCH 05/12] drm/client: Nuke outdated fastboot comment
Ville Syrjala
ville.syrjala at linux.intel.com
Thu Apr 4 20:33:29 UTC 2024
From: Ville Syrjälä <ville.syrjala at linux.intel.com>
Remove the tall tale about fastboot vs. user mode vs.
adjusted mode. crtc->mode == crtc->state->mode, so none
of this makes any sense. I suppose it may have been true
long ago in the past.
Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
---
drivers/gpu/drm/drm_client_modeset.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu/drm/drm_client_modeset.c
index 8ef03608b424..cf1de06f99aa 100644
--- a/drivers/gpu/drm/drm_client_modeset.c
+++ b/drivers/gpu/drm/drm_client_modeset.c
@@ -690,16 +690,6 @@ static bool drm_client_firmware_config(struct drm_client_dev *client,
/* last resort: use current mode */
if (!modes[i]) {
/*
- * IMPORTANT: We want to use the adjusted mode (i.e.
- * after the panel fitter upscaling) as the initial
- * config, not the input mode, which is what crtc->mode
- * usually contains. But since our current
- * code puts a mode derived from the post-pfit timings
- * into crtc->mode this works out correctly.
- *
- * This is crtc->mode and not crtc->state->mode for the
- * fastboot check to work correctly.
- *
* FIXME using legacy crtc->mode with atomic drivers
* is dodgy. Switch to crtc->state->mode, after taking
* care of the resulting locking/lifetime issues.
--
2.43.2
More information about the Intel-gfx
mailing list