[PATCH i-g-t v2] lib/kunit: Read results from debugfs

[Lucas De Marchi]

On Wed, Apr 10, 2024 at 08:28:40PM +0200, Janusz Krzysztofik wrote:
>Hi Lucas,
>
>On Friday, 5 April 2024 19:54:53 CEST Janusz Krzysztofik wrote:
>> KUnit can provide KTAP reports from test modules via debugfs files, one
>> per test suite.  Using that source of test results instead of extracting
>> them from dmesg, where they may be interleaved with other kernel messages,
>> seems more easy to handle and less error prone.  Switch to it.
>>
>> If KUnit debugfs support is found not configured then fall back to legacy
>> processing path.
>>
>> v2: Check validity of debugfs argument before calling kunit_get_tests()
>>     (Kamil),
>>   - replace multiple openat() + fdopen/fdopendir(), each followed by an
>>     error check, with less expensive fopen/opendir() of file/dir pathname
>>     components concatentated to a local buffer, protected from buffer
>>     overflow or truncation with a single check for enough buffer space
>>     (Lucas),
>>   - avoid confusing 'if' statement condition (Lucas).
>
>Could you please confirm if your R-b still applies?

yes, LGTM.


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

thanks
Lucas De Marchi