[PATCH] drm/i915/psr: Use crtc_state->port_clock instead of intel_dp->link_rate

Hogander, Jouni jouni.hogander at intel.com
Thu Apr 11 09:20:10 UTC 2024


On Thu, 2024-04-11 at 05:32 +0000, Manna, Animesh wrote:
> 
> 
> > -----Original Message-----
> > From: Hogander, Jouni <jouni.hogander at intel.com>
> > Sent: Tuesday, April 9, 2024 2:28 PM
> > To: intel-gfx at lists.freedesktop.org
> > Cc: Manna, Animesh <animesh.manna at intel.com>; Hogander, Jouni
> > <jouni.hogander at intel.com>
> > Subject: [PATCH] drm/i915/psr: Use crtc_state->port_clock instead
> > of
> > intel_dp->link_rate
> > 
> > Intel_dp->link_rate is not yet set at this point. Instead use
> > crtc_state-
> > > port_clock.
> > 
> > Fixes: 0dd21f836983 ("drm/i915/psr: Silence period and lfps half
> > cycle")
> > Signed-off-by: Jouni Högander <jouni.hogander at intel.com>
> 
> Reviewed-by: Animesh Manna <animesh.manna at intel.com>

Thank you Animesh for your review. This is now pushed to drm-intel-
next.

BR,

Jouni Högander

> 
> > ---
> >  drivers/gpu/drm/i915/display/intel_psr.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> > b/drivers/gpu/drm/i915/display/intel_psr.c
> > index 7af974bb41ca..f5b33335a9ae 100644
> > --- a/drivers/gpu/drm/i915/display/intel_psr.c
> > +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> > @@ -1276,7 +1276,7 @@ static int
> > _lnl_compute_aux_less_alpm_params(struct intel_dp *intel_dp,
> >         aux_less_wake_lines = intel_usecs_to_scanlines(&crtc_state-
> > > hw.adjusted_mode,
> >                                                       
> > aux_less_wake_time);
> > 
> > -       if (!_lnl_get_silence_period_and_lfps_half_cycle(intel_dp-
> > >link_rate,
> > +       if
> > +(!_lnl_get_silence_period_and_lfps_half_cycle(crtc_state-
> > >port_clock,
> >                                                         
> > &silence_period,
> >                                                         
> > &lfps_half_cycle))
> >                 return false;
> > --
> > 2.34.1
> 



More information about the Intel-gfx mailing list